Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BUG super_ocf_log - case sensitive matching prevent setting SAPHa… #245

Open
wants to merge 1 commit into
base: maintenance-classic
Choose a base branch
from

Conversation

PeterPitterling
Copy link
Contributor

…naFilter to all | none - all others worked

broken since [810d1d9]

Copy link
Member

@fmherschel fmherschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, if I want message type and filter values always to be bound to upper case. What is /was the issue behind that?

@PeterPitterling
Copy link
Contributor Author

The old implementation used the grep "ignore" flag

echo "$shf"| grep -iq ${mtype}; search=$?

The coding is specifying the message type always UPPER case .. FLOW, INFO , etc

The new implementation used the UPPER flag ..
declare -u SAPHanaFilter='ra-act-dec-lpa'

But for the values 'all' and 'none' this was not working as the CASE statement compared it lower case to these 2 values.

This PR ensures, whatever is specified .. no matter in coding or set directly in cluster attributes will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants