-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed escape characters format to handle warning due to misinterpretation of syntax #6585
Conversation
Can one of the admins verify this patch? |
Fixes #1868 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The reported test failures on CIrcleCI are unrelated. |
Thanks, the failing test blocks me from merging the changes. |
The failing tests are being resolved as we speak on a separate PR (#6582). Please give us a bit of time to merge this at which point everything should turn green for you as well. |
I would love to work on this issue . And i would like to know is there some issue unfix I would like to work on that. |
Could you try rebasing your branch on the current master to get the latest changes? The CircleCI runners don't do that automatically. Thank you! |
44a7a14
to
1ba43e1
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
@shachar-a Thank you for your contribution! |
Fixes #
Added '' to strings containing ''. A single '' results in taking the following char as an escape character.
Existing code results with the following warnings:
/home/shachar/OpenSource/hpx/build3/docs/sphinx/conf.py:75: SyntaxWarning: invalid escape sequence '\p'
if "/// \page" in line:
/home/shachar/OpenSource/hpx/build3/docs/sphinx/conf.py:76: SyntaxWarning: invalid escape sequence '\p'
title = line.split("/// \page", 1)[-1].strip()
/home/shachar/OpenSource/hpx/build3/docs/sphinx/conf.py:77: SyntaxWarning: invalid escape sequence '\h'
elif "/// \headerfile" in line:
/home/shachar/OpenSource/hpx/build3/docs/sphinx/conf.py:78: SyntaxWarning: invalid escape sequence '\h'
header = line.split("/// \headerfile", 1)[-1].strip()
Proposed Changes
Add '' to single ''
Any background context you want to provide?
Checklist
Not all points below apply to all pull requests.