Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Continuous Integration #700

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Fix Continuous Integration #700

merged 7 commits into from
Jan 24, 2025

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Jan 23, 2025

Continuous Integration is broken due to it not being up to date.

  • Fix the matrix for linux.yml to not request GCC and Clang versions that are too old.
  • Fix the matrix for mac.yml to not request Clang versions that are too old.
  • Fix Coverage breaks...
  • Fix System Tests do not install cargo and cbindgen
  • Fix Regression Tests do not install cargo and cbindgen
  • "Fix" clang-format checking...

@SSoelvsten SSoelvsten added the 📁 build CMake, GitHub Actions etc. label Jan 23, 2025
@SSoelvsten SSoelvsten self-assigned this Jan 23, 2025
@SSoelvsten SSoelvsten changed the title Fix unit test matrices Fix Unit Test (matrices) and System Tests (prompts) Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.038%. Comparing base (97a7a20) to head (6ba20bc).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #700   +/-   ##
=========================================
  Coverage   98.038%   98.038%           
=========================================
  Files           93        93           
  Lines         7137      7137           
=========================================
  Hits          6997      6997           
  Misses         140       140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 23, 2025

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of 7.41% (stdev: 21.74%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 10866.10 10061.40
Standard Deviation 2362.11 206.86

Number of samples: 10

Copy link

github-actions bot commented Jan 23, 2025

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -0.09% (stdev: 1.08%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 11615.70 11626.50
Standard Deviation 30.59 125.73

Number of samples: 10

Copy link

github-actions bot commented Jan 23, 2025

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -0.08% (stdev: 0.92%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 22343.50 22362.40
Standard Deviation 205.76 190.41

Number of samples: 10

Copy link

github-actions bot commented Jan 23, 2025

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -0.08% (stdev: 0.85%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 5133.50 5137.60
Standard Deviation 43.43 37.67

Number of samples: 10

Copy link

github-actions bot commented Jan 23, 2025

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -0.11% (stdev: 0.54%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 12111.60 12125.40
Standard Deviation 63.13 64.99

Number of samples: 10

Copy link

github-actions bot commented Jan 23, 2025

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of 0.04% (stdev: 0.41%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 15196.40 15190.30
Standard Deviation 62.05 50.02

Number of samples: 10

Copy link

github-actions bot commented Jan 23, 2025

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of 0.07% (stdev: 2.88%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 5081.00 5077.60
Standard Deviation 127.14 146.42

Number of samples: 10

There are multiple issues:
- It does not only check the diff, but all files.
- It complains about places that are properly formatted (since this particular GitHub Action
  has no ability to change the 'clang-format' version).
- The action itself seems slightly broken (compared to its README)
Copy link

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -0.12% (stdev: 2.23%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 9373.30 9384.20
Standard Deviation 208.90 203.63

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -0.46% (stdev: 1.25%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 16985.00 17063.30
Standard Deviation 148.83 212.63

Number of samples: 10

Copy link

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -0.66% (stdev: 1.76%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 29127.20 29318.00
Standard Deviation 187.23 516.88

Number of samples: 10

@SSoelvsten SSoelvsten changed the title Fix Unit Test (matrices) and System Tests (prompts) Fix Continuous Integration Jan 23, 2025
Copy link

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of 0.02% (stdev: 0.16%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 125238.00 125217.00
Standard Deviation 184.86 205.46

Number of samples: 4

Copy link

🟡 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of -5.52% (stdev: 20.75%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 67225.40 70937.80
Standard Deviation 10947.87 14723.11

Number of samples: 10

Copy link

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/ci/ubuntu-upgrade' is a change in performance of 0.74% (stdev: 0.84%).

... origin/main ssoelvsten/adiar/ci/ubuntu-upgrade
Mean 268755.67 266759.67
Standard Deviation 2257.71 449.78

Number of samples: 3

@SSoelvsten SSoelvsten merged commit 1aa125e into main Jan 24, 2025
56 checks passed
@SSoelvsten SSoelvsten deleted the ci/ubuntu-upgrade branch January 24, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 build CMake, GitHub Actions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant