Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDview #146

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

IDview #146

wants to merge 1 commit into from

Conversation

madhuriupadhye
Copy link
Contributor

No description provided.

Signed-off-by: Madhuri Upadhye <[email protected]>
@madhuriupadhye madhuriupadhye marked this pull request as draft January 13, 2025 10:52
@madhuriupadhye
Copy link
Contributor Author

@danlavu can you roughly overview this?
Please let me know for any changes

@danlavu
Copy link

danlavu commented Jan 14, 2025

I don't think this is how we should do it because this won't work for users. The command is different for users, groups and hosts, so we can rename the class to reflect the corresponding object. Maybe we should make a subclass or a method in the existing class, like

ipa.user("test user").add_idview(name="override_user")
ipa.host(["client"]).add_idview(["override_host"](

or a subclass

ipa.user("test user").add().override(name="override_user").add()

The thing I would like to see is that the parameters match the corresponding values in the parent class, so it's easier to write. The args for home directory in ideviews is 'homedir" but we are using "home" as an example.

Does this sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants