ipa: do not attempt to kinit if features are already detected #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinit was run every time this property was accessed. This caused "Calling exit but enter was not called" exception in pytest-mh under special conditions: - a test fails in a way that leaves IPA inoperable - IPA restore does not work - new test has `builtwith` marker that access IPA.features In this case kinit was called, failed and exepction was thrown. pytest-mh then skipped setup but attempted to teardown
|
The condition is also handled directly in next-actions/pytest-mh#92 but it is still good to avoid unnecessary kinit call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kinit was run every time this property was accessed. This caused
"Calling exit but enter was not called" exception in pytest-mh
under special conditions:
builtwithmarker that access IPA.featuresIn this case kinit was called, failed and exepction was thrown.
pytest-mh then skipped setup but attempted to teardown