Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: https://spandigital.atlassian.net/browse/PRSDM-6419 - Made some minor styling fixes on navigation #2

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

fix: https://spandigital.atlassian.net/browse/PRSDM-6419 - Made some minor styling fixes on navigation #2

wants to merge 20 commits into from

Conversation

aLR8
Copy link

@aLR8 aLR8 commented Nov 14, 2024 •
edited
Loading

JIRA Ticket

  • Updated border under brand name to be full width of column and also made it so it doesn't scroll with the navigation.
  • Updated font-weight of nav-items to be normal and not bold.

Screenshot 2024-11-14 at 10 37 22

@aLR8 aLR8 self-assigned this Nov 14, 2024
@aLR8 aLR8 marked this pull request as draft November 14, 2024 08:41
@aLR8 aLR8 marked this pull request as ready for review November 20, 2024 12:04
DustinFischer
DustinFischer requested changes Nov 25, 2024
View reviewed changes
Copy link

@DustinFischer DustinFischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aLR8 please can you link to the JIRA ticket?

@SamShiels
Copy link
Contributor

SamShiels commented Nov 26, 2024 •
edited by richardwooding
Loading

hey @aLR8. Have you tested this on the Client1 sites too?

@aLR8
Copy link
Author

aLR8 commented Dec 3, 2024

@DustinFischer I added the JIRA link.

@SamShiels I tested it on the KMDS site I'm working on.

@aLR8 aLR8 requested a review from DustinFischer December 3, 2024 11:45
mpilo-khathwane
mpilo-khathwane approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mpilo-khathwane mpilo-khathwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlRitterDev CharlRitterDev CharlRitterDev approved these changes

@mpilo-khathwane mpilo-khathwane mpilo-khathwane approved these changes

@christopherbrunsdon christopherbrunsdon Awaiting requested review from christopherbrunsdon

@Quantumplate Quantumplate Awaiting requested review from Quantumplate

@SamShiels SamShiels Awaiting requested review from SamShiels

@DustinFischer DustinFischer Awaiting requested review from DustinFischer

Assignees

@aLR8 aLR8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aLR8 @SamShiels @mpilo-khathwane @DustinFischer @CharlRitterDev @Quantumplate