Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: PRSDM-6980 Upgrade Bootstrap JS to v5.3.3 #16

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: PRSDM-6980 Upgrade Bootstrap JS to v5.3.3 #16

wants to merge 6 commits into from

Conversation

julianbyte
Copy link
Contributor

@julianbyte julianbyte commented Jan 21, 2025 •
edited
Loading

Description

  • Remove Bootstrap CSS import
  • Upgraded Bootstrap JS to v5.3.3
  • Used the minified version of Bootstrap JS
  • Removed unnecessary Bootstrap components and adjust layout for consistency

Issue

Screenshots

pr-screenshot.mp4

PR Readiness Checks

  • Your PR title conforms to conventional commits <type>: <jira-ticket-num><title>, for example: fix: PRSDM-123 issue with login with a maximum of 100 characters
  • You have performed a self-review of your changes via the GitHub UI
  • Comments were added to new code that can not explain itself (see reference 1 and reference 2)
  • New code adheres to the following quality standards:

@julianbyte julianbyte requested a review from a team as a code owner January 21, 2025 21:01
@julianbyte julianbyte mentioned this pull request Jan 21, 2025
Draft
4 tasks
@julianbyte julianbyte force-pushed the bootstrap-upgrade-clean branch from acf21bf to 1a5ee4f Compare January 21, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlRitterDev CharlRitterDev CharlRitterDev approved these changes

@christopherbrunsdon christopherbrunsdon Awaiting requested review from christopherbrunsdon christopherbrunsdon is a code owner automatically assigned from SPANDigital/span-presidium-dev

@Quantumplate Quantumplate Awaiting requested review from Quantumplate Quantumplate is a code owner automatically assigned from SPANDigital/span-presidium-dev

@NicholasDunham NicholasDunham Awaiting requested review from NicholasDunham NicholasDunham is a code owner automatically assigned from SPANDigital/span-presidium-dev

@Gerrit-van-Niekerk Gerrit-van-Niekerk Awaiting requested review from Gerrit-van-Niekerk Gerrit-van-Niekerk is a code owner automatically assigned from SPANDigital/span-presidium-dev

@mpilo-khathwane mpilo-khathwane Awaiting requested review from mpilo-khathwane mpilo-khathwane is a code owner automatically assigned from SPANDigital/span-presidium-dev

@DustinFischer DustinFischer Awaiting requested review from DustinFischer DustinFischer is a code owner automatically assigned from SPANDigital/span-presidium-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianbyte @CharlRitterDev