Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PRSDM-7037 data-section to return correct path.Dir instead of return /_index.md #12

Closed
wants to merge 1 commit into from

Conversation

christopherbrunsdon
Copy link
Contributor

Description

data-section includes the suffix "/_index.md", see ticket for details.

This PR reverts change to parse .Path as a path to resolve article bar skeleton loader not loading because it the API call with /_index.md returns an empty result.

Issue

Screenshots

Resolved:

image image

PR Readiness Checks

  • Your PR title conforms to conventional commits <type>: <jira-ticket-num><title>, for example: fix: PRSDM-123 issue with login with a maximum of 100 characters
  • You have performed a self-review of your changes via the GitHub UI
  • Comments were added to new code that can not explain itself (see reference 1 and reference 2)
  • New code adheres to the following quality standards:

@christopherbrunsdon
Copy link
Contributor Author

Closing: Newer versions of Hugo do not need this fix, this impacts older versions of hugo. Solution is to update to newer hugo.

@christopherbrunsdon christopherbrunsdon deleted the fix/PRSDM-7037-data-section-fix branch December 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant