Fix GRAAL_HOME/JVMCI_BIN handling in som and fix field access implementation
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to allow failing benchmarks though and ignore the failing job, because perf segfaults… Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
yuria4-enable-profiling
branch
from
58b4466 to
2e492a0
Compare
Signed-off-by: Stefan Marr <[email protected]>
Things to consider: - what to do when the expected layout is invalid? - what to do when the accesses object is outdated? don’t want a cache entry for that, since it gets removed immedietly - how to handle the transition from expected primitive write to something else? Signed-off-by: Stefan Marr <[email protected]>
We haven’t handle those yet… Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
yuria4-enable-profiling
branch
from
e7a8c97 to
485e54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The launcher wasn't properly using the environment variables.
Think the changed version is more what I would expect.
Field access in FieldAccessorNode had a few issues:
This change should be performance neutral, but may not be: https://rebench.dev/TruffleSOM/compare/1bc7250d08356fe9ea7cb8525064231cd39c4e4e..58b446652be9a6281b462f9b8cea1c8c2b5bc5ec