Move the code for searching particles/cells into a separate utility class #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The classes
ParticleSnapshot,CellSnapshot, andTetraMeshSpatialGrideach contained a customized variation of the code for creating and using a search data structure that can efficiently find particles/cells overlapping a given position or ray (half-line). With this update, this code has been unified, streamlined and moved into a separate utility class calledBoxSearch.Motivation
Reducing code duplication benefits maintainability. Moreover, this functionality is now easily available for other (future) classes that may need it.
Tests
All functional tests work unchanged (binary compatible). Search performance for the tested larger models is similar to that in the previous version of the code.