Fixing Errors #38
Fixing Errors #38
Conversation
Changes Done: - Moved positioning of file output to inside of try block to correct scope of 'r' variable. Testing Done: - Testing done on batman server cluster.
Changes Done: - Added section explaining to install a needed dependency. Changes Done: - Testing done on batman server cluster.
|
r should be scoped to the function as try/except doesn't create its own scope. |
Description: - Fixed the alerting error that was flagged by CJHouser
|
@cjhouser Can you please provide a line number for the other error you are flagging? I can't seem to find a alert that happens outside the try catches for this pr. Thanks! |
Description: - Fixed an issue where an error in the log (such as when there is an alert) causes grafana.py to crash.
| @@ -20,16 +20,16 @@ def alert(data): | |||
| info["embeds"].append({'description': data}) | |||
| try: | |||
| r = requests.post(url, data=json.dumps(info), headers={'Content-type': 'application/json'}) | |||
| except Exception as e: | |||
| print_to_file("Alerting (discord) - {}: {}\n".format(r.status_code, r.reason)) | |||
There was a problem hiding this comment.
Put line 23 in an 'else:' block following the 'except:' block. The else block will run if no exception is caught and will also keep the try/except from throwing an exception if the file write fails in print_to_file().
For reference: https://docs.python.org/3/tutorial/errors.html#handling-exceptions
Ctrl+F for 'else clause'
monitoring/monitoring-client.py
Outdated
| if monitor_config['DEFAULT']['slack']: | ||
| url = monitor_config['DEFAULT']['slack'] | ||
| try: | ||
| r = requests.post(url, data=json.dumps({'text':'{}'.format(data)}), headers={'Content-type': 'application/json'}) | ||
| print_to_file("Alerting (slack) - {}: {}\n".format(r.status_code, r.reason)) |
This pull request includes a fix for monitoring-client.py where a variable 'r' was outside of the necessary scope, as well as a fix to the monitoring README file where it was lacking a command to install a needed dependency.