Updated the AGP version from 7.4.2 to 8.0.2 and modified gradlew (app… #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) of bundleclient to be consistent with that of bundletransport
breed
reviewed
Jun 13, 2024
| implementation 'io.grpc:grpc-netty-shaded:1.50.2' | ||
| implementation 'io.grpc:grpc-protobuf:1.50.2' | ||
| implementation 'io.grpc:grpc-stub:1.50.2' | ||
| compileOnly 'org.apache.tomcat:annotations-api:6.0.53' // necessary for Java 9+ |
There was a problem hiding this comment.
do we actually need netty and tomcat? (perhaps okhttp needs netty?)
There was a problem hiding this comment.
We need Tomcat but not Netty. Removed netty in the latest commit.
|
it's interesting that bundle client failed on protoc but bundle transport did not... |
breed
approved these changes
Jun 14, 2024
03fernanda-palacios
pushed a commit
that referenced
this pull request
Jun 20, 2024
#85) * Updated the AGP version from 7.4.2 to 8.0.2 and modified gradlew (app) of bundleclient to be consistent with that of bundletransport
03fernanda-palacios
pushed a commit
that referenced
this pull request
Jun 20, 2024
#85) * Updated the AGP version from 7.4.2 to 8.0.2 and modified gradlew (app) of bundleclient to be consistent with that of bundletransport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…) of bundleclient to be consistent with that of bundletransport