Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workflow #84

Closed
wants to merge 7 commits into from
Closed

update workflow #84

wants to merge 7 commits into from

Conversation

gokris165
Copy link
Collaborator

No description provided.

@breed
Copy link
Contributor

breed commented Jun 14, 2024

if this changed worked, the checks shouldn't be waiting right?

@gokris165
Copy link
Collaborator Author

gokris165 commented Jun 14, 2024

Nope, sorry this was just me experimenting with the workflows. I ended up creating my own repo for experimentation and found a working solution with Personal Access Tokens (PAT). The downside is that it requires the repo owner to create a PAT for their GitHub account, and then add that to this repo as a repo secret. And then we can use the PAT during our workflow to trigger the checks. I wrote about it on a thread in the discord server about very recently (my apologies on the late response).

This PR shouldn't be merged / should be closed.
Here's the link to the repo with the working solution: PAT Solution

@gokris165 gokris165 closed this Jun 14, 2024
@gokris165
Copy link
Collaborator Author

The steps to get the checks working again are somewhat explained in the repo readme but I can also fix it once you add the PAT as a secret to this repo. But I don't know if we want to go ahead with the PAT solution because maybe token security is a concern, there were a few people unhappy with this solution on the GitHub forums even though this is GitHub's recommended solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants