security changes #342
Merged
security changes #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pankinkun
commented
Sep 26, 2024
pankinkun
commented
- move server keys to android-core resourcem -> allowing transport to utilize the keys
- create transport security to for key management and generation using signal EC KeyPair
- rename client security files using SecurityUtils static variables
- move server keys to android-core resourcem -> allowing transport to utilize the keys - create transport security to for key management and generation using signal EC KeyPair - rename client security files using SecurityUtils static variables
breed
approved these changes
Sep 26, 2024
| @@ -33,6 +33,7 @@ | |||
| import java.util.concurrent.CompletableFuture; | |||
| import java.util.logging.Logger; | |||
|
|
|||
|
|
|||
| @@ -85,6 +103,7 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| fragments.add(new TitledFragment(getString(R.string.logs), new LogFragment())); | |||
| TabLayout tabLayout = findViewById(R.id.tabs); | |||
| viewPager2 = findViewById(R.id.view_pager); | |||
|
|
|||
| @@ -411,7 +411,7 @@ public BundleExchangeCounts doExchangeWithTransport(String deviceAddress, String | |||
| } | |||
|
|
|||
| private int uploadBundle(BundleExchangeServiceGrpc.BundleExchangeServiceStub stub) throws RoutingExceptions.ClientMetaDataFileException, IOException, InvalidKeyException, GeneralSecurityException { | |||
| BundleDTO toSend = generateBundleForTransmission(); | |||
| BundleDTO toSend = generateBundleForTransmission(); | |||
mysignal/app/build.gradle
Outdated
| @@ -4,11 +4,11 @@ plugins { | |||
| } | |||
|
|
|||
| android { | |||
| compileSdk 34 | |||
| compileSdk 33 | |||
There was a problem hiding this comment.
do we still want to do this?
ManasC478
pushed a commit
that referenced
this pull request
Sep 27, 2024
- move server keys to android-core resourcem -> allowing transport to utilize the keys - create transport security to for key management and generation using signal EC KeyPair - rename client security files using SecurityUtils static variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.