Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELinux policy for cockpit #740

Merged
merged 17 commits into from
Jan 30, 2024
Merged

Add SELinux policy for cockpit #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cc46c32
SELinux policy for cockpit
dsugar100 Dec 11, 2023
4bd6277
Fix denial while cleaning up pidfile symlink
dsugar100 Dec 11, 2023
4f90070
allow system --user to execute systemd-tmpfiles in <user>_systemd_tmp…
dsugar100 Dec 11, 2023
c199c29
cockpit ssh as user
dsugar100 Dec 11, 2023
fddef57
Allow sudo dbus chat w/sysemd-logind
dsugar100 Dec 11, 2023
a242691
The L+ tmpfiles option needs to read the symlink
dsugar100 Dec 11, 2023
6751444
Signal during logout
dsugar100 Dec 11, 2023
7abf353
This seems important for administrative access
dsugar100 Dec 11, 2023
cb81021
This works instead of allow exec on user_tmpfs_t!
dsugar100 Dec 11, 2023
b34ce38
admin can read/write web socket
dsugar100 Dec 11, 2023
fcfffd4
Allow key manipulation
dsugar100 Dec 11, 2023
b4d2d58
Add dontaudit to quiet down a bit
dsugar100 Dec 11, 2023
c6d904f
Add watches
dsugar100 Dec 11, 2023
a95feb6
Additional access for systemctl
dsugar100 Dec 11, 2023
d80c8f4
Denial during cockpit use
dsugar100 Dec 11, 2023
08ea302
Fix password changing from cockpit login screen
dsugar100 Jan 12, 2024
882830d
Resolve error when cockpit initiate shutdown
dsugar100 Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion policy/modules/admin/sudo.if
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ template(`sudo_role_template',`

# allow getting the process group of the parent process
allow $1_sudo_t $2:process getpgid;
allow $1_sudo_t $2:unix_stream_socket rw_socket_perms;

# allow accessing /proc/pid/stat of the calling domain
ps_process_pattern($1_sudo_t, $2)
Expand Down Expand Up @@ -199,7 +200,7 @@ template(`sudo_role_template',`
')

optional_policy(`
dbus_system_bus_client($1_sudo_t)
auth_use_pam_systemd($1_sudo_t)

ifdef(`init_systemd',`
init_dbus_chat($1_sudo_t)
Expand Down
1 change: 1 addition & 0 deletions policy/modules/kernel/corecommands.fc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ ifdef(`distro_debian',`
/usr/share/cluster/.*\.sh gen_context(system_u:object_r:bin_t,s0)
/usr/share/cluster/ocf-shellfuncs -- gen_context(system_u:object_r:bin_t,s0)
/usr/share/cluster/svclib_nfslock -- gen_context(system_u:object_r:bin_t,s0)
/usr/share/cockpit/motd/update-motd -- gen_context(system_u:object_r:bin_t,s0)
/usr/share/cvs/contrib/rcs2log -- gen_context(system_u:object_r:bin_t,s0)
/usr/share/e16/misc(/.*)? gen_context(system_u:object_r:bin_t,s0)
/usr/share/gedit/plugins/externaltools/tools(/.*)? gen_context(system_u:object_r:bin_t,s0)
Expand Down
18 changes: 18 additions & 0 deletions policy/modules/kernel/devices.if
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,24 @@ interface(`dev_dontaudit_list_all_dev_nodes',`
dontaudit $1 device_t:dir list_dir_perms;
')

########################################
## <summary>
## Dontaudit attempts to execute device nodes.
## </summary>
## <param name="domain">
## <summary>
## Domain to not audit.
## </summary>
## </param>
#
interface(`dev_dontaudit_execute_dev_nodes',`
gen_require(`
type device_t;
')

dontaudit $1 device_t:file execute;
')

########################################
## <summary>
## Add entries to directories in /dev.
Expand Down
93 changes: 93 additions & 0 deletions policy/modules/kernel/files.if
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2927,6 +2927,25 @@ interface(`files_dontaudit_read_default_files',`
dontaudit $1 default_t:file read_file_perms;
')

########################################
## <summary>
## Do not audit attempts to execute files
## with the default file type.
## </summary>
## <param name="domain">
## <summary>
## Domain to not audit.
## </summary>
## </param>
#
interface(`files_dontaudit_execute_default_files',`
gen_require(`
type default_t;
')

dontaudit $1 default_t:file execute;
')

########################################
## <summary>
## Create, read, write, and delete files with
Expand Down Expand Up @@ -3756,6 +3775,26 @@ interface(`files_dontaudit_read_etc_runtime_files',`
dontaudit $1 etc_runtime_t:file { getattr read };
')

########################################
## <summary>
## Do not audit attempts to execuite files
## in /etc that are dynamically
## created on boot, such as mtab.
## </summary>
## <param name="domain">
## <summary>
## Domain to not audit.
## </summary>
## </param>
#
interface(`files_dontaudit_execuite_etc_runtime_files',`
gen_require(`
type etc_runtime_t;
')

dontaudit $1 etc_runtime_t:file execute;
')

########################################
## <summary>
## Do not audit attempts to read files
Expand Down Expand Up @@ -6869,6 +6908,24 @@ interface(`files_rw_runtime_dirs',`
rw_dirs_pattern($1, var_run_t, var_run_t)
')

########################################
## <summary>
## Watch /var/lib directories.
## </summary>
## <param name="domain">
## <summary>
## Domain allowed access.
## </summary>
## </param>
#
interface(`files_watch_var_lib_dirs',`
gen_require(`
type var_lib_t;
')

allow $1 var_lib_t:dir watch;
')

########################################
## <summary>
## Watch /var/run directories.
Expand All @@ -6887,6 +6944,24 @@ interface(`files_watch_runtime_dirs',`
allow $1 var_run_t:dir watch;
')

########################################
## <summary>
## Watch /var directories.
## </summary>
## <param name="domain">
## <summary>
## Domain allowed access.
## </summary>
## </param>
#
interface(`files_watch_var_dirs',`
gen_require(`
type var_t;
')

allow $1 var_t:dir watch;
')

########################################
## <summary>
## Read generic runtime files.
Expand Down Expand Up @@ -6925,6 +7000,24 @@ interface(`files_exec_runtime',`
exec_files_pattern($1, var_run_t, var_run_t)
')

########################################
## <summary>
## Dontaudit attempt to execute generic programs in /var/run in the caller domain.
## </summary>
## <param name="domain">
## <summary>
## Domain allowed access.
## </summary>
## </param>
#
interface(`files_dontaudit_exec_runtime',`
gen_require(`
type var_run_t;
')

dontaudit $1 var_run_t:file execute;
')

########################################
## <summary>
## Read and write generic runtime files.
Expand Down
4 changes: 4 additions & 0 deletions policy/modules/roles/sysadm.te
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,10 @@ optional_policy(`
cobbler_admin(sysadm_t, sysadm_r)
')

optional_policy(`
cockpit_admin(sysadm_t)
')

optional_policy(`
collectd_admin(sysadm_t, sysadm_r)
')
Expand Down
2 changes: 2 additions & 0 deletions policy/modules/services/chronyd.if
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ interface(`chronyd_enabledisable',`
class service { enable disable };
')

chronyd_status($1)
allow $1 chronyd_unit_t:service { enable disable };
')

Expand All @@ -276,6 +277,7 @@ interface(`chronyd_startstop',`
class service { start stop };
')

chronyd_status($1)
allow $1 chronyd_unit_t:service { start stop };
')

Expand Down
20 changes: 20 additions & 0 deletions policy/modules/services/cockpit.fc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# cockpit stuff

/etc/cockpit/ws-certs\.d(/.*)? gen_context(system_u:object_r:cockpit_cert_t,s0)

/run/cockpit(/.*)? gen_context(system_u:object_r:cockpit_runtime_t,s0)
/run/cockpit/certificate-helper(/.*) gen_context(system_u:object_r:cockpit_cert_t,s0)

/usr/lib/systemd/system/cockpit.* -- gen_context(system_u:object_r:cockpit_unit_t,s0)

/usr/libexec/cockpit-certificate-ensure -- gen_context(system_u:object_r:cockpit_cert_manage_exec_t,s0)
/usr/libexec/cockpit-ws -- gen_context(system_u:object_r:cockpit_ws_exec_t,s0)
/usr/libexec/cockpit-tls -- gen_context(system_u:object_r:cockpit_ws_exec_t,s0)
/usr/libexec/cockpit-wsinstance-factory -- gen_context(system_u:object_r:cockpit_ws_exec_t,s0)
/usr/libexec/cockpit-session -- gen_context(system_u:object_r:cockpit_session_exec_t,s0)
/usr/libexec/cockpit-ssh -- gen_context(system_u:object_r:cockpit_session_exec_t,s0)

/var/lib/cockpit(/.*)? gen_context(system_u:object_r:cockpit_state_t,s0)

/var/run/cockpit(/.*)? gen_context(system_u:object_r:cockpit_runtime_t,s0)
/var/run/cockpit-ws(/.*)? gen_context(system_u:object_r:cockpit_runtime_t,s0)
Loading
Loading