Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new 'DAE Solver' category; put IDA-like things in it. #115

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

luciansmith
Copy link
Contributor

IDA solvers are ODE solvers plus algebraic rules, not steady state solvers.

IDA solvers are ODE solvers plus algebraic rules, not steady state solvers.
KINSOL and the 'method for solving a system of linear equations'.

It may be that some of the children of this are actually DAE solvers, but if so, someone with more knowledge than I is going to have to tell us.
@luciansmith luciansmith requested a review from nickerso March 14, 2024 00:40
@luciansmith
Copy link
Contributor Author

This PR stemmed from Logan noticing that when VCell told SED-ML it used IDA to solve some things, it would refuse to try to run those on Copasi or Roadrunner. However, the models in question didn't actually need IDA; they just happened to use IDA on a problem that was actually just ODEs, with no DAEs in it. So now, the IDA family of solvers is now removed from the steady state solvers (where they didn't belong) and is now in its own DAE branch, where everything is tagged as solving DAE problems (KiSAO 373) as well as ODE problems (374). If you ask libkisao for a list of ODE solvers, it gives you both lists, and if you ask it for DAE solvers, it just gives you those.

In addition, the KINSOL solver and the 'method for solving a system of linear equations' branch were tagged as being DAE solvers, which they are not, so I removed that tag from them. It's possible that one of the children of that branch are? Maybe? But this is well beyond my knowledge.

@luciansmith luciansmith merged commit 25411be into dev Mar 14, 2024
7 checks passed
@luciansmith luciansmith deleted the create-dae-solver branch March 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant