fix: fix incorrect module ref in custom-elements-manifest #10497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is wrong data in the produced custom-elements-manifest -
TableMoveEventDetail
andListMoveEventDetail
types are referenced with the wrong module. Instead being related to the List and Table classes, the types are related to thebase class: "@ui5/webcomponents-basedist/util/dragAndDrop/DragRegistry.js"
Indeed the real type (
MoveEventDetail
) is in the DragRegistry base util class and the components are just re-exporting via casting:And, the custom-elements-manifest analyzer can't deal with this - it takes the DragRegistry as the source module.
Temporary fix will be to to create a local type and think of a convention rule or enhancing the analyser: