Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect module ref in custom-elements-manifest #10497

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jan 8, 2025

There is wrong data in the produced custom-elements-manifest - TableMoveEventDetail and ListMoveEventDetail types are referenced with the wrong module. Instead being related to the List and Table classes, the types are related to the
base class: "@ui5/webcomponents-basedist/util/dragAndDrop/DragRegistry.js"

Indeed the real type (MoveEventDetail) is in the DragRegistry base util class and the components are just re-exporting via casting:

import type { MoveEventDetail as ListMoveEventDetail } from "@ui5/webcomponents-base/dist/util/dragAndDrop/DragRegistry.js";

export type {
    ListMoveEventDetail,
};

And, the custom-elements-manifest analyzer can't deal with this - it takes the DragRegistry as the source module.
Temporary fix will be to to create a local type and think of a convention rule or enhancing the analyser:

type ListMoveEventDetail = MoveEventDetail;
export type {
    ListMoveEventDetail,
};

@ilhan007 ilhan007 closed this Jan 8, 2025
@ilhan007 ilhan007 reopened this Jan 8, 2025
@ilhan007 ilhan007 merged commit ea8cdea into main Jan 9, 2025
12 of 18 checks passed
@ilhan007 ilhan007 deleted the fix-module-ref-in-cem branch January 9, 2025 08:19
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.6.2 🎉

The release is available on v2.6.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants