Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui5-select): migrate to tsx template #10469

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore(ui5-select): migrate to tsx template #10469

merged 3 commits into from
Jan 16, 2025

Conversation

kgogov
Copy link
Member

@kgogov kgogov commented Jan 6, 2025

Related to: #10046

horizontalAlign="Start"
hideArrow={true}
preventInitialFocus={true}
onui5-open={this._afterOpen}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onOpen, onBeforeOpen, onClose should be available on ResponsivePopover

selectionMode="SingleAuto"
separators="None"
onMouseDown={this._itemMousedown}
onui5-item-click={this._handleItemPress}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you should use onItemClick.
We only need to use "onui5-" on elements that don't emit the expected event, for example if we want to listen on a "div", wrapping a List, then we must use "onui5-item-click", because the "div" does not have such an event.
Whenever we listen on web component level, we can use the camelCase event name that is also suggested and autocompleted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification! This makes perfect sense now. I appreciate the detailed explanation.

@kgogov kgogov requested review from dobrinyonkov and removed request for kineticjs January 14, 2025 11:56
@kgogov kgogov merged commit e8d4647 into main Jan 16, 2025
10 checks passed
@kgogov kgogov deleted the select-tsx branch January 16, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants