Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: AI Button Animation #10424

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

PoC: AI Button Animation #10424

wants to merge 17 commits into from

Conversation

NHristov-sap
Copy link
Contributor

@NHristov-sap NHristov-sap commented Dec 19, 2024

This is a copy of another PR #10242 , but this time animations should be done with keyframes.

@NHristov-sap
Copy link
Contributor Author

It seems that animations don't

@NHristov-sap
Copy link
Contributor Author

NHristov-sap commented Dec 19, 2024

It seems that keyframes animations don't work in Chrome/Edge because of Chrome bug - if the @keyframes definitions are located in the CSS files of the components to which exported parts belong - everything works fine in Chrome/Edge, but if these definitions are in the main CSS (of the AI Button) - animations work only in Firefox. For example:

@keyframes fadeOutText {...} should stay in <ui5-ai-button> CSS
@keyframes fadeOutIcon {...}, @keyframes fadeOutEndIcon {...} should stay in <ui5-button> CSS
@keyframes fadeOutArrowButton {...} should stay in <ui5-split-button> CSS

then all works fine, otherwise if all of these are in <ui5-ai-button> CSS, animations work only in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant