-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-flexible-column-layout): add arrow icon functionality #10362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also noticed accidentally that onSeparatorPress
is triggered when we press an arrow. Did not seem like a big issue but we can add e.g:
if (e.target as HTMLElement === this.startArrowDOM) {
return;
}
to the beginning of onSeparatorPress
to prevent it starting an obsolete separatorMovementSession
upon arrow-click
🎉 This PR is included in version v2.7.0-rc.1 🎉 The release is available on v2.7.0-rc.1 Your semantic-release bot 📦🚀 |
switchLayoutOnArrowPress
ThreeColumnsStartHiddenMidExpanded
andThreeColumnsStartHiddenEndExpanded
_onArrowKeydown
function is triggeredJIRA: BGSOFUIPIRIN-6623