Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-flexible-column-layout): add arrow icon functionality #10362

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

NakataCode
Copy link
Contributor

@NakataCode NakataCode commented Dec 11, 2024

  • Added the icon in the FCL tsx template(positioned in the first separator)
  • Added styling for the arrow button
  • Added functionality for the arrow button, so we can toggle the first column switchLayoutOnArrowPress
  • The icon property of the button dynamically chooses an arrow icon based on the startArrowDirection property.
  • Added two new layouts ThreeColumnsStartHiddenMidExpanded and ThreeColumnsStartHiddenEndExpanded
  • Added keyboard handling for the arrow, when Enter or Space is pressed on the button, the _onArrowKeydown function is triggered
  • Added keyboard handling for left and right key on the arrow
  • Added new sample in the test page
  • Added tests

JIRA: BGSOFUIPIRIN-6623

@NakataCode NakataCode requested a review from kineticjs December 11, 2024 14:01
@NakataCode NakataCode marked this pull request as ready for review December 16, 2024 10:21
packages/fiori/src/FlexibleColumnLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/fcl-utils/FCLLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/FlexibleColumnLayoutTemplate.tsx Outdated Show resolved Hide resolved
packages/fiori/src/fcl-utils/FCLLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/FlexibleColumnLayout.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@kineticjs kineticjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also noticed accidentally that onSeparatorPress is triggered when we press an arrow. Did not seem like a big issue but we can add e.g:

if (e.target as HTMLElement === this.startArrowDOM) {
	return;
}

to the beginning of onSeparatorPress to prevent it starting an obsolete separatorMovementSession upon arrow-click

packages/fiori/src/FlexibleColumnLayout.ts Outdated Show resolved Hide resolved
packages/fiori/src/themes/FlexibleColumnLayout.css Outdated Show resolved Hide resolved
@kineticjs kineticjs merged commit 61b94ae into main Jan 22, 2025
10 checks passed
@NakataCode NakataCode deleted the fcl-arrow-handling branch January 22, 2025 15:49
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.7.0-rc.1 🎉

The release is available on v2.7.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants