feat(ui5-timeline-item): introduce state property
#10277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
requested changes
Dec 2, 2024
There was a problem hiding this comment.
- From the commit description - the semantic meaning gets set over the
ui5-timeline-itemand not only over the icon. - You could add a test, in order to check whether the
accessible-descriptionproperty results intoaria-descriptionover the inner element.
Tested with NVDA and JAWS. The announcements are as expected.
unazko
reviewed
Dec 3, 2024
unazko
requested changes
Dec 4, 2024
unazko
reviewed
Dec 4, 2024
unazko
approved these changes
Dec 4, 2024
Stoev
reviewed
Dec 6, 2024
vladitasev
reviewed
Jan 7, 2025
vladitasev
requested changes
Jan 7, 2025
hinzzx
changed the title
state property
unazko
approved these changes
Jan 16, 2025
vladitasev
approved these changes
Jan 20, 2025
|
🎉 This PR is included in version v2.7.0-rc.1 🎉 The release is available on v2.7.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
stateproperty into the<ui5-timeline-item>web component.The
stateproperty allows you to set the semantic state of the icon using the following values:Information,Positive,Critical,NegativeorNone.Each state automatically changes the icon's color to visually represent the corresponding state, improving clarity and consistency.
The
stateis also accessible. Screen readers will read the text, ensuring that users with assistive technologies can understand the semantic meaning.Sample usecases with and without
statepropertyWith
Without
Fixes: #9806