chore(ui5-shellbar): evolution redesign introduced #10264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onents into navigation
Co-authored-by: Dobrin Dimchev <[email protected]> Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
…onents into navigation
With the new design if we have a notifications-count attr and/or an ui5-shellbar-item with count attr we now display different badges on the overflow button. If none of the above is present, no badge is displayed.
Arrow navigation is added for the ui5-shellbar
--------- Co-authored-by: yanaminkova <[email protected]> Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
* Add shellbar additional context separators (#10108) * feat(ui5-shellbar): added arrow navigation * refactor(ui5-shellbar): start and end separators --------- Co-authored-by: yanaminkova <[email protected]> Co-authored-by: PetyaMarkovaBogdanova <[email protected]> * feat(ui5-shellbar): added applySideNavigationStyles property The new applySideNavigationStyles makes sure to apply the correct CSS paddings/styles to the ShellBar specified by visual design when ShellBar is used as adjacent to ui5-side-navigation. * chore: ShellBar sample updated ShellBar is now a header slot to NavigationLayout in its sample HTML file. Additionally the padding specific styling for it is changed in NavigationLayout CSS to implement visual spec. * chore: shellBar is now a header slot to NavigationLayout in its sample HTML file Additionally the padding specific styling for it is changed in NavigationLayout CSS to implement visual spec. --------- Co-authored-by: Petya Markova <[email protected]> Co-authored-by: yanaminkova <[email protected]> Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
Co-authored-by: Dobrin Dimchev <[email protected]>
Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
* chore: new overflow logic * chore: clean
Screen reader support is added for the `ui5-shellbar`
Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
…onents into chore-shellbar-evolution
…onents into chore-shellbar-evolution
…onents into chore-shellbar-evolution
…onents into chore-shellbar-evolution
…onents into chore-shellbar-evolution
…onents into chore-shellbar-evolution
…onents into chore-shellbar-evolution
…onents into chore-shellbar-evolution
dobrinyonkov
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've introduced new design for the 'ui5-shellbar' web component.
The new elements include:
startContentandendContentwhich are accepting various web components and are visualized in the middle area of theui5-shellbarbetween the branding and overflow actions. Elements in this area implement their own hiding/showing behavior based on order assigned using thedata-hide-orderattribute.