feat(ui5-menu): Enhance keyboard navigation #10243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
reviewed
Nov 25, 2024
unazko
reviewed
Nov 25, 2024
unazko
reviewed
Nov 25, 2024
Todor-ads
changed the title
unazko
reviewed
Nov 25, 2024
vladitasev
requested changes
Jan 23, 2025
| } else if ((shouldCloseMenu || isTabNextPrevious) && parentElement._popover) { | ||
| parentElement._popover.open = false; | ||
| parentElement.selected = false; | ||
| const opener = this._popover.getOpenerHTMLElement(parentElement._popover.opener); |
There was a problem hiding this comment.
Move this code to Popover.ts, create a new function called focusOpener(), add Teo Taushanov and Pepi Dimov for review.
The new function calls this.getOpener.......?focus(), annotate as @protected
| } | ||
|
|
||
| get _navigableItems(): Array<HTMLElement> { | ||
| return [...this.endContent]; |
There was a problem hiding this comment.
What would happen if the user passes non-interactive items in endContent? I saw the documentation says we expect button, link or icon( I presume button-like icon, i.e. clickable). But will there be an issue if they pass a normal static icon or just a div?
Even if it doesn't work in such scenarios, it should not break. Please check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, it will be possible to navigate through the elements added to the endContent using the left and right arrow keys on the keyboard
BGSOFUIBALKAN-8852