Skip to content

Commit

Permalink
fix(SelectDialog): set search input type to "search" (#6791)
Browse files Browse the repository at this point in the history
  • Loading branch information
Lukas742 authored Jan 9, 2025
1 parent ad9937a commit 9919542
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const Default: Story = {
return (
<ListItemStandard
selected={index === 1}
image={currentProduct.img}
image={<img src={currentProduct.img} alt="Example Image" />}
description={`${currentProduct.description}${index}`}
key={`${currentProduct.text}${index}`}
>
Expand Down Expand Up @@ -156,7 +156,7 @@ export const MultiSelect: Story = {
}
return (
<ListItemStandard
image={currentProduct.img}
image={<img src={currentProduct.img} alt="Example Image" />}
description={`${currentProduct.description}${index}`}
data-description={`${currentProduct.description}${index}`}
key={`${currentProduct.text}${index}`}
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/components/SelectDialog/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import ButtonDesign from '@ui5/webcomponents/dist/types/ButtonDesign.js';
import IconMode from '@ui5/webcomponents/dist/types/IconMode.js';
import InputType from '@ui5/webcomponents/dist/types/InputType.js';
import ListSelectionMode from '@ui5/webcomponents/dist/types/ListSelectionMode.js';
import iconDecline from '@ui5/webcomponents-icons/dist/decline.js';
import iconSearch from '@ui5/webcomponents-icons/dist/search.js';
Expand Down Expand Up @@ -306,6 +307,7 @@ const SelectDialog = forwardRef<DialogDomRef, SelectDialogPropTypes>((props, ref
placeholder={i18nBundle.getText(SEARCH)}
onInput={handleSearchInput}
onKeyUp={handleSearchSubmit}
type={InputType.Search}
icon={
<>
{searchValue && (
Expand Down

0 comments on commit 9919542

Please sign in to comment.