Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: role collection name handling #194

Merged
merged 5 commits into from
Dec 4, 2024
Merged

fix: role collection name handling #194

merged 5 commits into from
Dec 4, 2024

Conversation

lechnerc77
Copy link
Member

@lechnerc77 lechnerc77 commented Nov 29, 2024

Purpose

Does this introduce a breaking change?

[X] Yes - Output of names in JSON changes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
make test

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

Although the readability suffers this change will keep our functionality working independent of any SAP internal or customer specific naming conventions
As it is consistent for all resources this approach was chosen instead of replacements that are likely cot covering 100% of the cases.

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Project board and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up issues are created and linked.

@lechnerc77 lechnerc77 self-assigned this Nov 29, 2024
@lechnerc77 lechnerc77 added bug Something isn't working breaking-change Breaking change labels Nov 29, 2024
@lechnerc77 lechnerc77 added this to the v0.2.0-beta1 milestone Nov 29, 2024
@lechnerc77 lechnerc77 enabled auto-merge (squash) November 29, 2024 09:24
@lechnerc77 lechnerc77 disabled auto-merge December 3, 2024 14:48
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@lechnerc77 lechnerc77 enabled auto-merge (squash) December 3, 2024 14:55
@lechnerc77 lechnerc77 requested a review from CHERIANS December 4, 2024 09:06
Copy link
Contributor

@CHERIANS CHERIANS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lechnerc77 lechnerc77 merged commit c130372 into main Dec 4, 2024
10 of 11 checks passed
@lechnerc77 lechnerc77 deleted the issue-189 branch December 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Exporter uses role collection name as resource name
2 participants