Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove duplicate i18n key (CXSPA-9287) #19914

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Conversation

kimhw0630
Copy link
Contributor

@kimhw0630 kimhw0630 requested a review from a team as a code owner January 22, 2025 21:24
@github-actions github-actions bot marked this pull request as draft January 22, 2025 21:24
@kimhw0630 kimhw0630 marked this pull request as ready for review January 22, 2025 21:36
Copy link

cypress bot commented Jan 22, 2025

spartacus    Run #46878

Run Properties:  status check passed Passed #46878  •  git commit 5f004f05c0 ℹ️: Merge f7351109b5c5bf031511aaa821f5508bd93de8e0 into e54be34a38c1985e08bdf00de12c...
Project spartacus
Branch Review feat/CXSPA-9287
Run status status check passed Passed #46878
Run duration 13m 31s
Commit git commit 5f004f05c0 ℹ️: Merge f7351109b5c5bf031511aaa821f5508bd93de8e0 into e54be34a38c1985e08bdf00de12c...
Committer Hak Woo Kim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft January 23, 2025 12:56
@kimhw0630 kimhw0630 marked this pull request as ready for review January 23, 2025 14:13
Copy link
Contributor

@rmch91 rmch91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot marked this pull request as draft January 24, 2025 11:16
@kimhw0630 kimhw0630 marked this pull request as ready for review January 24, 2025 14:25
@github-actions github-actions bot marked this pull request as draft January 24, 2025 15:01
@kimhw0630 kimhw0630 marked this pull request as ready for review January 24, 2025 17:50
@github-actions github-actions bot marked this pull request as draft January 27, 2025 14:06
@kimhw0630 kimhw0630 marked this pull request as ready for review January 27, 2025 21:05
@kimhw0630 kimhw0630 merged commit c66d4f9 into develop Jan 27, 2025
28 checks passed
@kimhw0630 kimhw0630 deleted the feat/CXSPA-9287 branch January 27, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants