Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CXSPA-9076 ACC 264.1 (Level A): Product Configuration _ Link _ Item count not read #19912

Merged
merged 8 commits into from
Jan 23, 2025
Merged

fix: CXSPA-9076 ACC 264.1 (Level A): Product Configuration _ Link _ Item count not read #19912

merged 8 commits into from
Jan 23, 2025

Conversation

andreighervan7
Copy link
Contributor

@andreighervan7 andreighervan7 commented Jan 22, 2025 •
edited
Loading

ticket CXSPA-9076

@andreighervan7 andreighervan7 requested a review from a team as a code owner January 22, 2025 11:33
@github-actions github-actions bot marked this pull request as draft January 22, 2025 11:33
StanislavSukhanov
StanislavSukhanov requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove <ng-container> wrapper.

@StanislavSukhanov StanislavSukhanov self-requested a review January 22, 2025 21:18
StanislavSukhanov
StanislavSukhanov requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments ;)

StanislavSukhanov
StanislavSukhanov approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit

@andreighervan7 andreighervan7 marked this pull request as ready for review January 23, 2025 14:01
@github-actions github-actions bot marked this pull request as draft January 23, 2025 14:01
@andreighervan7 andreighervan7 marked this pull request as ready for review January 23, 2025 14:05
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@cypress Cypress
Copy link

cypress bot commented Jan 23, 2025

spartacus    Run #46838

Run Properties:  status check passed Passed #46838  •  git commit 6d93dd0164 ℹ️: Merge 6dc22a8b9d7609ebe1d4872b89c8412a52e4842e into 910d6c8cb9b2aaba2e6797344040...
Project spartacus
Branch Review feature/CXSPA-9076-ACC-2641-Level-A-v22
Run status status check passed Passed #46838
Run duration 04m 56s
Commit git commit 6d93dd0164 ℹ️: Merge 6dc22a8b9d7609ebe1d4872b89c8412a52e4842e into 910d6c8cb9b2aaba2e6797344040...
Committer andreighervan7
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@andreighervan7 andreighervan7 merged commit 165ad48 into develop Jan 23, 2025
30 of 42 checks passed
@andreighervan7 andreighervan7 deleted the feature/CXSPA-9076-ACC-2641-Level-A-v22 branch January 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavSukhanov StanislavSukhanov StanislavSukhanov approved these changes

@Zeyber Zeyber Zeyber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreighervan7 @Zeyber @StanislavSukhanov