Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-9055) - Region associated headers #19883

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: (CXSPA-9055) - Region associated headers #19883

merged 2 commits into from
Jan 21, 2025

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Jan 17, 2025

Closes: CXSPA-9055

All the regions within the organization page should now be associated with a header they already contain.

@Pio-Bar Pio-Bar requested a review from a team as a code owner January 17, 2025 11:07
@github-actions github-actions bot marked this pull request as draft January 17, 2025 11:07
@Pio-Bar Pio-Bar marked this pull request as ready for review January 17, 2025 11:08
@cypress Cypress
Copy link

cypress bot commented Jan 17, 2025 •
edited
Loading

spartacus    Run #46771

Run Properties:  status check passed Passed #46771  •  git commit c665a0afa4 ℹ️: Merge 0a9dc622ce64a866959ccccecb6f40170e29a579 into 1c29fdc50e992c1ec3b94d9a448e...
Project spartacus
Branch Review feature/CXSPA-9055
Run status status check passed Passed #46771
Run duration 03m 48s
Commit git commit c665a0afa4 ℹ️: Merge 0a9dc622ce64a866959ccccecb6f40170e29a579 into 1c29fdc50e992c1ec3b94d9a448e...
Committer PioBar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@Zeyber Zeyber requested a review from a team January 20, 2025 13:39
@github-actions github-actions bot marked this pull request as draft January 21, 2025 08:32
@Pio-Bar Pio-Bar marked this pull request as ready for review January 21, 2025 08:32
@cypress Cypress
Copy link

cypress bot commented Jan 21, 2025

spartacus    Run #46770

Run Properties:  status check passed Passed #46770  •  git commit 7cea43fe4f: Region associated headers
Project spartacus
Branch Review feature/CXSPA-9055
Run status status check passed Passed #46770
Run duration 13m 38s
Commit git commit 7cea43fe4f: Region associated headers
Committer PioBar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 22
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 815
View all changes introduced in this branch ↗︎

@Pio-Bar Pio-Bar merged commit dd575f6 into develop Jan 21, 2025
28 checks passed
@Pio-Bar Pio-Bar deleted the feature/CXSPA-9055 branch January 21, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petarmarkov9449 petarmarkov9449 petarmarkov9449 approved these changes

@Zeyber Zeyber Zeyber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pio-Bar @Zeyber @petarmarkov9449