Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXSPA-8968: Domain Values on Demand implementation #19876

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

Larisa-Staroverova
Copy link
Contributor

No description provided.

@Larisa-Staroverova Larisa-Staroverova requested review from a team as code owners January 16, 2025 13:17
@github-actions github-actions bot marked this pull request as draft January 16, 2025 13:17
@Uli-Tiger Uli-Tiger marked this pull request as ready for review January 22, 2025 09:43
Copy link

cypress bot commented Jan 22, 2025

spartacus    Run #46807

Run Properties:  status check passed Passed #46807  •  git commit 3a9b272022 ℹ️: Merge cb72336784b3c995b0d8392fda2006befc489f69 into 4e3fa84d60038f8a0f1106846e20...
Project spartacus
Branch Review feature/CXSPA-8968
Run status status check passed Passed #46807
Run duration 04m 48s
Commit git commit 3a9b272022 ℹ️: Merge cb72336784b3c995b0d8392fda2006befc489f69 into 4e3fa84d60038f8a0f1106846e20...
Committer LarisaStar
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@Uli-Tiger Uli-Tiger marked this pull request as draft January 22, 2025 10:24
@Larisa-Staroverova Larisa-Staroverova marked this pull request as ready for review January 22, 2025 11:14
Copy link
Contributor Author

@Larisa-Staroverova Larisa-Staroverova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, have a look at my comments.
By the way this test:
ConfigAttributeHeaderComponent > Render corresponding part of the component > should not render "show more options" button when domainOnDemand is false
is failing when the tests are randomly executed.

@github-actions github-actions bot marked this pull request as draft January 22, 2025 16:25
Uli-Tiger
Uli-Tiger previously approved these changes Jan 23, 2025
Copy link
Contributor

@Uli-Tiger Uli-Tiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants