-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXSPA-8968: Domain Values on Demand implementation #19876
base: develop
Are you sure you want to change the base?
Conversation
…per UI-Type from back-end
…and OccConfigurationVariantAdapter to handle domain attributes
spartacus Run #46807
Run Properties:
|
Project |
spartacus
|
Branch Review |
feature/CXSPA-8968
|
Run status |
Passed #46807
|
Run duration | 04m 48s |
Commit |
3a9b272022 ℹ️: Merge cb72336784b3c995b0d8392fda2006befc489f69 into 4e3fa84d60038f8a0f1106846e20...
|
Committer | LarisaStar |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
4
|
Pending |
2
|
Skipped |
0
|
Passing |
125
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, have a look at my comments.
By the way this test:
ConfigAttributeHeaderComponent > Render corresponding part of the component > should not render "show more options" button when domainOnDemand is false
is failing when the tests are randomly executed.
...figurator/rulebased/components/attribute/header/configurator-attribute-header.component.html
Outdated
Show resolved
Hide resolved
...figurator/rulebased/components/attribute/header/configurator-attribute-header.component.html
Outdated
Show resolved
Hide resolved
...urator/rulebased/components/attribute/header/configurator-attribute-header.component.spec.ts
Outdated
Show resolved
Hide resolved
...urator/rulebased/components/attribute/header/configurator-attribute-header.component.spec.ts
Outdated
Show resolved
Hide resolved
...urator/rulebased/components/attribute/header/configurator-attribute-header.component.spec.ts
Outdated
Show resolved
Hide resolved
...ct-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.spec.ts
Outdated
Show resolved
Hide resolved
...product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.ts
Outdated
Show resolved
Hide resolved
feature-libs/product-configurator/rulebased/styles/_configurator-attribute-header.scss
Show resolved
Hide resolved
feature-libs/product-configurator/rulebased/styles/_configurator-attribute-header.scss
Outdated
Show resolved
Hide resolved
feature-libs/product-configurator/rulebased/styles/_configurator-attribute-header.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.