fix: (CXSPA-9014) ThemeSwitcher List item _ Value count not read out #19863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StanislavSukhanov
commented
Jan 14, 2025
StanislavSukhanov
commented
- closes https://jira.tools.sap/browse/CXSPA-9014
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9014-List-item-_-Value-count-not-read
|
| Run status |
|
| Run duration | 04m 01s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
petarmarkov9449
previously approved these changes
Jan 16, 2025
Zeyber
previously approved these changes
Jan 16, 2025
| get activeItem$(): Observable<string> { | ||
| return this.themeSwitcherComponentService.getActiveItem(); | ||
| } | ||
| set activeItem(value: string) { | ||
| this.themeSwitcherComponentService.setActive(value); | ||
| } | ||
|
|
||
| ariaLabel$( |
There was a problem hiding this comment.
Lets include a unit test for this.
There was a problem hiding this comment.
@Zeyber done.
StanislavSukhanov
force-pushed
the
feature/CXSPA-9014-List-item-_-Value-count-not-read
branch
from
eae9def to
912646c
Compare
Zeyber
approved these changes
Jan 21, 2025
Merge Checks Failed |
StanislavSukhanov
deleted the
feature/CXSPA-9014-List-item-_-Value-count-not-read
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.