Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate existing apps with application builder to use index.server.html in server file #19848

Open
wants to merge 3 commits into
base: epic/upgrade-to-angular-19
Choose a base branch
from

Conversation

pawelfras
Copy link
Contributor

@pawelfras pawelfras commented Jan 9, 2025

This PR provides an automation that migrates SPA apps using application builder (created with SPA >=2211.19) to use server/index.server.html instead of browser/index.html due to changes in Angular 19 and what's the output of built application.

QA (installation script):

  • change version of all packages to 2212.32.0 (temporary test value)
  • build and deploy Spartacus packages locally:
    npx ts-node ./tools/schematics/testing.ts in the SPA root folder
  • create new app npx @angular/cli@17 new my-app --standalone=false --style=scss --routing=false
  • go to the project's directory and install latest SPA 2211.x, e.g. from RBSC
  • migrate to Angualr 18, then 19 (following migration docs
  • update SPA to v2212.32.0:
    `npx @angular/cli@17 update @spartacus/schematics@latest
  • verify if migration runs (logs in console):
    image
  • verify server.ts file if changes are applied:
    image
  • run npm run build and NODE_TLS_REJECT_UNAUTHORIZED=0 run serve:ssr:my-app to test if app works

@pawelfras pawelfras requested a review from a team as a code owner January 9, 2025 13:25
@pawelfras pawelfras mentioned this pull request Jan 9, 2025
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant