fix: (CXSPA-9041) Popover directive HCT contrast #19835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed a contrast of a contend displayed in popover when HCT is applied; * closes https://jira.tools.sap/browse/CXSPA-9041
* fixed a contrast of a contend displayed in popover when HCT is applied; * closes https://jira.tools.sap/browse/CXSPA-9041
Merge Checks Failed |
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9041-HCT-popover-styling
|
| Run status |
|
| Run duration | 11m 23s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Zeyber
requested changes
Jan 8, 2025
| ) | ||
| ? // we need to select first child element, | ||
| // otherwise HCT theming isn't getting picked up. | ||
| this.winRef.document.body.firstElementChild |
There was a problem hiding this comment.
Maybe we should let this fall back to body in case firstElementChild isn't found for whatever reason. SSR and non-ssr spartacus builds and installations can be a bit inconsistent with their DOM structures immediately after the body tag (eg. sometimes app-root is not added to the DOM).
Fallback example:
this.winRef.document.body.firstElementChild ?? this.winRef.document.body
There was a problem hiding this comment.
thanks for your comment. it's fixed
* fixed a contrast of a contend displayed in popover when HCT is applied; * closes https://jira.tools.sap/browse/CXSPA-9041
…tyling' into feature/CXSPA-9041-HCT-popover-styling
Zeyber
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a contrast of a contend displayed in popover when HCT is applied;
closes https://jira.tools.sap/browse/CXSPA-9041