Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: As a customer, I want to request OTP and use it to register an account on B2C Composable Storefront #19828

Merged
merged 19 commits into from
Jan 15, 2025
Merged

feat: As a customer, I want to request OTP and use it to register an account on B2C Composable Storefront #19828

merged 19 commits into from
Jan 15, 2025

Conversation

Melody-zhou-512
Copy link
Contributor

@Melody-zhou-512 Melody-zhou-512 requested review from a team as code owners January 6, 2025 02:56
@github-actions github-actions bot marked this pull request as draft January 6, 2025 02:56
github-actions bot and others added 3 commits January 6, 2025 02:56
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 7, 2025 01:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

i53577
i53577 reviewed Jan 7, 2025
View reviewed changes
feature-libs/user/account/assets/translations/en/userAccount.json Outdated
@@ -16,7 +16,7 @@
"wrongEmailFormat": "This is not a valid email format."
},
"verificationTokenForm": {
"createVerificationToken": "Verification code sent to {{target}}. Please check and enter the code.",
"createVerificationToken": "Verification code has been sent to {{target}}. Please enter the code.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not modify existing one, add a new one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to mockup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what grace said is always use new entry when you want to update text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX inform me to modify this.

Copy link
Contributor

@scarai-sap scarai-sap Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX does't know the detail of how to make code backward compatibility....

Any text change is not allowed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok got it!

@i53577 i53577 changed the title feature/CXSPA-3919:As a customer, I want to request OTP and use it to register an account on B2C Composable Storefront feat: As a customer, I want to request OTP and use it to register an account on B2C Composable Storefront Jan 8, 2025
@github-actions github-actions bot marked this pull request as draft January 13, 2025 09:11
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 13, 2025 09:11
@Melody-zhou-512
fix pr issue
b29d93c 
fix pr issue
@github-actions github-actions bot marked this pull request as draft January 13, 2025 09:58
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 13, 2025 09:58
@Melody-zhou-512
fix sonar issue
7be8cca 
fix sonar issue
@github-actions github-actions bot marked this pull request as draft January 14, 2025 05:50
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 14, 2025 05:50
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft January 14, 2025 05:51
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 14, 2025 05:51
@Melody-zhou-512
fix code review comments
8f10c35 
fix code review comments
@github-actions github-actions bot marked this pull request as draft January 15, 2025 02:35
@Melody-zhou-512
fix code review comments
2ba85c7 
fix code review comments
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 15, 2025 03:11
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft January 15, 2025 03:11
@Melody-zhou-512
fix code review comments
dd732b7 
fix code review comments
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 15, 2025 03:14
i53577
i53577 reviewed Jan 15, 2025
View reviewed changes
...ents/registration-verification-token-form/verify-register-verification-token-form.service.ts Outdated
@Injectable()
export class RegistrationVerificationTokenFormComponentService {
constructor(
protected globalMessageService: GlobalMessageService,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use inject instead of constructor

@Melody-zhou-512
fix code review comments
dddefa8 
fix code review comments
@github-actions github-actions bot marked this pull request as draft January 15, 2025 09:14
@Melody-zhou-512 Melody-zhou-512 changed the base branch from develop to feature/register-otp-rate-limit January 15, 2025 09:56
@Melody-zhou-512 Melody-zhou-512 marked this pull request as ready for review January 15, 2025 09:56
@Melody-zhou-512 Melody-zhou-512 merged commit 7fc7c43 into feature/register-otp-rate-limit Jan 15, 2025
11 checks passed
@Melody-zhou-512 Melody-zhou-512 deleted the feature/CXSPA-3919 branch January 15, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarai-sap scarai-sap scarai-sap left review comments

@i53577 i53577 i53577 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Melody-zhou-512 @scarai-sap @i53577