Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a11y tab component to plp facets #19244

Merged
merged 111 commits into from
Oct 30, 2024
Merged

feat: Add a11y tab component to plp facets #19244

merged 111 commits into from
Oct 30, 2024

Conversation

Zeyber
Copy link
Contributor

@Zeyber Zeyber commented Sep 16, 2024

No description provided.

Zeyber added 30 commits April 27, 2021 12:31
@Zeyber
feat: Agnostic a11y-tabs component
5b1a887
@Zeyber
Merge branch 'develop' into feature/GH-11637
d44be15
@Zeyber
Add tab/accordian modes
f5a1a35
@Zeyber
order for accordian
3b11487
@Zeyber
Add pdp styling
f73e778
@Zeyber
Merge branch 'develop' into feature/GH-11637
a1b5146
@Zeyber
start moving tabs to facets
d4bfb9f
@Zeyber
experimenting with facets
6a2dbcd
@Zeyber
get tabs working in facets
4bfbe50
@Zeyber
Merge branch 'develop' into feature/GH-11637
7650c1c
@Zeyber
Merge branch 'feature/GH-11637' of https://github.com/SAP/cloud-comme…
5038041 
…rce-spartacus-storefront into feature/GH-11637
@Zeyber
Make tabs collapsable in accordian mode and tidy up
02b2d12
@Zeyber
changes
c05a32e
@Zeyber
Merge branch 'develop' into feature/GH-11637
1a471bd
@Zeyber
commit changes
4c2d829
@Zeyber
Merge branch 'develop' into feature/GH-11637
77e6e24
@Zeyber
Merge branch 'feature/GH-11637' of https://github.com/SAP/spartacus i…
2f71b4a 
…nto feature/GH-11637
@Zeyber
various improvements
48b9d18
@Zeyber
Merge branch 'develop' into feature/GH-11637
a7703b9
@Zeyber
format tab paragraph container dom
88e6d4c
@Zeyber
Merge branch 'develop' into feature/GH-11637
ca986cd
@Zeyber
bump feature level and fix imports
2638f73
@Zeyber
activate feature
6ae794f
@Zeyber
make separate tab-panel component
cd43233
@Zeyber
Merge branch 'develop' into feature/GH-11637
c9a51ad
@Zeyber
moving stuff and commenting
284762d
@Zeyber
Merge branch 'develop' into feature/GH-11637
6e582d8
@Zeyber
solving review comments
88ec4b7
@Zeyber
Merge branch 'feature/GH-11637' of https://github.com/SAP/spartacus i…
e2c05c2 
…nto feature/GH-11637
@Zeyber
add vars
353efc4
@github-actions github-actions bot marked this pull request as draft October 23, 2024 06:48
@sdrozdsap sdrozdsap marked this pull request as ready for review October 23, 2024 06:48
@github-actions github-actions bot marked this pull request as draft October 28, 2024 07:57
@Zeyber Zeyber marked this pull request as ready for review October 28, 2024 12:47
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 29, 2024 07:55
@Zeyber Zeyber marked this pull request as ready for review October 29, 2024 08:16
@Zeyber
Copy link
Contributor Author

Zeyber commented Oct 29, 2024

Note for testing
Feature is disabled by default while we work out some issues. To enable it, you need to open spartacus-features.module.ts and set a11yTabComponent to true.

@github-actions github-actions bot marked this pull request as draft October 30, 2024 06:32
@Zeyber Zeyber marked this pull request as ready for review October 30, 2024 06:36
@github-actions github-actions bot marked this pull request as draft October 30, 2024 07:15
@Zeyber Zeyber marked this pull request as ready for review October 30, 2024 07:37
@github-actions github-actions bot marked this pull request as draft October 30, 2024 12:03
@Zeyber Zeyber marked this pull request as ready for review October 30, 2024 12:03
@Zeyber Zeyber merged commit 052291b into develop Oct 30, 2024
28 checks passed
@Zeyber Zeyber deleted the feature/GH-11637-plp branch October 30, 2024 12:52
uroslates pushed a commit that referenced this pull request Nov 7, 2024
@Zeyber @ulates-sap
feat: Add a11y tab component to plp facets (#19244)
0e52b2e 
Closes: https://jira.tools.sap/browse/CXSPA-2581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrozdsap sdrozdsap sdrozdsap approved these changes

@developpeurweb developpeurweb developpeurweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zeyber @developpeurweb @sdrozdsap @Matejk00