Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): add option for configuring VHD dialog title heading level #12960

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat(platform): add option for configuring VHD dialog title heading level #12960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions libs/platform/value-help-dialog/value-help-dialog/value-help-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,20 @@
class="fdp-value-help-dialog__row fdp-value-help-dialog__selection-row"
[attr.aria-label]="'platformVHD.selectedAndConditionLabel' | fdTranslate"
>
<h5 fd-title class="selected-and-condition-title" [id]="id + '-selected-item'">
<span
role="heading"
[attr.aria-level]="_headingLevel()"
fd-title
class="selected-and-condition-title"
[id]="id + '-selected-item'"
>
@if (hasSelectedAndConditions) {
{{ 'platformVHD.selectedAndConditionLabel' | fdTranslate }}
({{ selectedItems.length + validConditions.length }})
} @else {
{{ 'platformVHD.selectedEmptyLabel' | fdTranslate }}
}
</h5>
</span>
<div class="fdp-value-help-dialog__tokens-wrapper">
<div class="fdp-value-help-dialog__tokens">
<!-- Selected items -->
Expand Down Expand Up @@ -284,7 +290,7 @@ <h5 fd-title class="selected-and-condition-title" [id]="id + '-selected-item'">
</div>
</ng-template>
<ng-template #dialogTitleText>
<h5 [attr.id]="headerId" fd-title>{{ dialogTitle }}</h5>
<span role="heading" [attr.aria-level]="_headingLevel()" [attr.id]="headerId" fd-title>{{ dialogTitle }}</span>
</ng-template>
<ng-template #tabLink let-title="title" let-type="type">
@if (selectedTab === type && showSelectionTab && showDefineTab) {
Expand All @@ -295,7 +301,7 @@ <h5 [attr.id]="headerId" fd-title>{{ dialogTitle }}</h5>
(click)="switchTab()"
[title]="'platformVHD.selectMobileTabBackBtnTitle' | fdTranslate"
></button>
<h5 fd-title>{{ title }}</h5>
<span role="heading" [attr.aria-level]="_headingLevel()" fd-title>{{ title }}</span>
}
@if (selectedTab !== type) {
<a
Expand All @@ -310,7 +316,9 @@ <h5 fd-title>{{ title }}</h5>
</ng-template>
<ng-template #advancedHeader>
<button fd-button glyph="navigation-left-arrow" fdType="transparent" (click)="toggleAdvancedSearch()"></button>
<h5 fd-title>{{ 'platformVHD.searchAdvancedSearchLabel' | fdTranslate }}</h5>
<span role="heading" [attr.aria-level]="_headingLevel()" fd-title>{{
'platformVHD.searchAdvancedSearchLabel' | fdTranslate
}}</span>
</ng-template>
<ng-template #desktopDialogTitle>
<ng-template [ngTemplateOutlet]="dialogTitleText"></ng-template>
Expand All @@ -321,7 +329,9 @@ <h5 fd-title>{{ 'platformVHD.searchAdvancedSearchLabel' | fdTranslate }}</h5>
@if (hasSelectedTab) {
<ng-template [ngTemplateOutlet]="selectedTabHeader"></ng-template>
} @else {
<h5 [attr.id]="headerId" fd-title>{{ dialogTitle }}</h5>
<span role="heading" [attr.aria-level]="_headingLevel()" [attr.id]="headerId" fd-title>{{
dialogTitle
}}</span>
}
</div>
<ng-template [ngTemplateOutlet]="mobileTabs"></ng-template>
Expand Down
14 changes: 13 additions & 1 deletion libs/platform/value-help-dialog/value-help-dialog/value-help-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ import {
ViewChild,
ViewEncapsulation,
computed,
inject
inject,
input
} from '@angular/core';
import { Observable, Subject, Subscription, filter, isObservable, of, take, tap } from 'rxjs';

Expand Down Expand Up @@ -49,6 +50,7 @@ import { FormControlComponent, FormLabelComponent } from '@fundamental-ngx/core/
import { LayoutGridColDirective, LayoutGridComponent, LayoutGridRowDirective } from '@fundamental-ngx/core/layout-grid';
import { ListIconDirective, ListLinkDirective, ListTitleDirective } from '@fundamental-ngx/core/list';
import { ScrollbarDirective } from '@fundamental-ngx/core/scrollbar';
import { HeadingLevel } from '@fundamental-ngx/core/shared';
import { SkeletonComponent } from '@fundamental-ngx/core/skeleton';
import { TabItemDirective, TabLinkDirective, TabNavComponent, TabTagDirective } from '@fundamental-ngx/core/tabs';
import { TitleComponent } from '@fundamental-ngx/core/title';
Expand Down Expand Up @@ -293,6 +295,16 @@ export class PlatformValueHelpDialogComponent<T = any> extends VhdComponent impl
@ViewChild('container', { read: TemplateRef })
dialogContainer: TemplateRef<any>;

/**
* Heading level of the dialog title.
*/
headingLevel = input<HeadingLevel>(5);

/** @hidden */
_headingLevel = computed(() =>
this.headingLevel() ? Number.parseInt(`${this.headingLevel()}`.replace(/\D/g, ''), 10) : undefined
);

/** @hidden */
activeDialog?: DialogRef;

Expand Down
Loading