fix(platform): table filter enhancement #12864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes [#11783](#11783) - Add support for formatting array values in table component - Fix format field name ## Before <img width="666" alt="Screenshot 2024-11-25 at 17 49 05" src="https://github.com/user-attachments/assets/dd9fe3fd-2e4f-4c03-b4fd-462d0a9b8429"> ## After <img width="854" alt="Screenshot 2024-11-25 at 17 49 53" src="https://github.com/user-attachments/assets/c76fcdd5-44f6-4b59-b3ac-7576f43f1989">
khotcholava
changed the title
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit fc4012d): https://fundamental-ngx-gh--pr12864-11783-feat-table-fil-fmzi4dev.web.app (expires Mon, 23 Dec 2024 14:51:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
khotcholava
changed the title
|
@khotcholava Let @droshev once you update it. |
closes [#11783](#11783) - Fixed formatting ## Before <img width="666" alt="Screenshot 2024-11-25 at 17 49 05" src="https://github.com/user-attachments/assets/dd9fe3fd-2e4f-4c03-b4fd-462d0a9b8429"> ## After <img width="854" alt="Screenshot 2024-11-25 at 17 49 53" src="https://github.com/user-attachments/assets/c76fcdd5-44f6-4b59-b3ac-7576f43f1989">
| return appliedFilters | ||
| .map((filter, index) => { | ||
| const separator = index < appliedFilters.length - 1 ? ', ' : ''; | ||
| return `${filter.columnName} (${filter.params})${separator}`; |
There was a problem hiding this comment.
It looks like this is working well to me but I am curious if this is the behavior we would be looking for with RTL languages. Not sure how that works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11783
Before
After