feat(core): dialog focus trap #12831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
|
Visit the preview URL for this PR (updated for commit 5d3fa9d): https://fundamental-ngx-gh--pr12831-12768-dialog-focus-i-b4yv1vvv.web.app (expires Sat, 11 Jan 2025 19:48:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
|
@dpavlenishvili @alexhristov14 can you review it? thanks |
alexhristov14
requested changes
Dec 20, 2024
| dialogRef.afterClosed.pipe( | ||
| takeUntilDestroyed(this._destroyRef) | ||
| ).subscribe(() => { | ||
| console.log(dialogConfig.focusTrapped); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12768
Ensure the button does not lose focus after the dialog is closed, improving usability and navigation flow.
Uploading Screen Recording 2024-12-09 at 13.36.32.mov…