Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): table growing button state #12817

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

khotcholava
Copy link
Contributor

closes #12793

Add conditional rendering to growing button component Implemented logic to display the growing button only if there are more items to load, using a conditional check. This ensures that the button is hidden once all items have been loaded.

Snapshots

Screen.Recording.2024-12-06.at.14.36.13.mov

closes [#12793](#12793)

Add conditional rendering to growing button component
Implemented logic to display the growing button only if there are more items to load, using a conditional check. This ensures that the button is hidden once all items have been loaded.
@khotcholava khotcholava self-assigned this Dec 6, 2024
@khotcholava khotcholava marked this pull request as ready for review December 6, 2024 10:39
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit bf11d3e
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/677ead7db640700008e68cc4
😎 Deploy Preview https://deploy-preview-12817--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 6, 2024

Visit the preview URL for this PR (updated for commit bf11d3e):

https://fundamental-ngx-gh--pr12817-12793-growing-button-tjoy6xfv.web.app

(expires Sat, 11 Jan 2025 17:00:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@khotcholava khotcholava force-pushed the 12793-growing-button-state branch from 23f811b to 8ae7683 Compare December 11, 2024 12:48
@droshev droshev added the table label Dec 18, 2024
@droshev droshev added this to the Sprint 141 - December 2024 milestone Dec 18, 2024
@droshev
Copy link
Contributor

droshev commented Dec 18, 2024

@dpavlenishvili @alexhristov14 Can you review it?

@droshev
Copy link
Contributor

droshev commented Dec 20, 2024

@mikerodonnell89 Can you take over? Akaki said he did the fix.

Copy link
Contributor

@alexhristov14 alexhristov14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an else statement where showing "n of n" is replacing the load more button as per issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Change growing button state when all items are loaded
4 participants