You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Focus should not be lost on closing the dialog, either the focus should be retained on the button or on the next active UI element.
Can you handle that on the application side
No
Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)
All
If this is a bug, please provide steps for reproducing it; the exact components you are using;
Create a component based dialog that has complex body with different ngx components.
Access the dialog button using keyboard Tab and close with Tab key.
Once closed, focus get closed from the dialog button and comes to top screen element.
Please provide relevant source code (if applicable).
Please provide stackblitz example(s).
You can try ngx examples, issue is reproducible there.
In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.
Yes, issue is raised by an accessibility expert.
Did you check the documentation and the API?
Yes
Did you search for similar issues?
Is there anything else we should know?
IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.
The text was updated successfully, but these errors were encountered:
* feat(core): dialog focus trap
closes [#12768](#12768)
Ensure the button does not lose focus after the dialog is closed, improving usability and navigation flow.
* fix(core): renaming, prevent console error if no active element
* fix: lint and test
---------
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Mike O'Donnell <[email protected]>
Is this a bug, enhancement, or feature request?
Bug
Describe your proposal.
Focus should not be lost on closing the dialog, either the focus should be retained on the button or on the next active UI element.
Can you handle that on the application side
No
Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)
All
If this is a bug, please provide steps for reproducing it; the exact components you are using;
Component used: Dialog
Please provide relevant source code (if applicable).
Please provide stackblitz example(s).
You can try ngx examples, issue is reproducible there.
In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.
Yes, issue is raised by an accessibility expert.
Did you check the documentation and the API?
Yes
Did you search for similar issues?
Is there anything else we should know?
IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.
The text was updated successfully, but these errors were encountered: