Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Change growing button state when all items are loaded #12793

Open
do-oel opened this issue Nov 29, 2024 · 0 comments · May be fixed by #12817
Open

Enhancement: Change growing button state when all items are loaded #12793

do-oel opened this issue Nov 29, 2024 · 0 comments · May be fixed by #12817
Assignees
@khotcholava
Labels
table

Comments

@do-oel
Copy link

do-oel commented Nov 29, 2024

Is this a bug, enhancement, or feature request?

Enhancement

Describe your proposal.

For platform tables with growing button: Currently, when all items in a table are loaded, the growing button still remains active and clickable although no more items can be loaded.

In this case, the growing button should be replaced by a non-interactive but focusable text stating "Showing n of n"

Current state:
image

Proposed changes:
image

Can you handle that on the application side

No
@droshev droshev added the table label Nov 29, 2024
khotcholava added a commit that referenced this issue Dec 6, 2024
@khotcholava
feat(platform): table growing button
215b193 
closes [#12793](#12793)

Add conditional rendering to growing button component
Implemented logic to display the growing button only if there are more items to load, using a conditional check. This ensures that the button is hidden once all items have been loaded.
@khotcholava khotcholava linked a pull request Dec 6, 2024 that will close this issue
Open
khotcholava added a commit that referenced this issue Dec 11, 2024
@khotcholava
fix(table): table filter toolbar
23f811b 
closes [#12793](#12793)

Fix format
khotcholava added a commit that referenced this issue Dec 11, 2024
@khotcholava
fix(platform): table filter toolbar
8ae7683 
closes [#12793](#12793)

Fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khotcholava khotcholava

Labels
table
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(platform): table growing button state SAP/fundamental-ngx
3 participants
@droshev @khotcholava @do-oel