-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement configuration for handling artifact ratings from a file #744
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit that I probably don't know enough of the whole codebase to really assess these considerably big changes properly. In addition, I don't have enough time in the next days to dig deeper here. 😞
Therefore, just a few remarks from my side that come to my mind:
- The additional (command-line) configuration option(s) should probably be documented on GitHub Pages, i.e. on https://sap.github.io/fosstars-rating-core/getting_oss_security_rating.html or https://sap.github.io/fosstars-rating-core/getting_oss_rules_of_play_rating.html
- Compared to the number of changes in the respective files and the additional option for configuration, the number of tests that have been changed or added seem to be rather small.
You are right. I will find some time to update the document. Also, I will work on the test cases :) |
Fixes #743 (duplicate)
Fixes #553