-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added release script #64
Conversation
This reverts commit e2e3a81.
@@ -0,0 +1,52 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Comment)
I'm sorry for all the python fans, but this could've been a single CLI line, like:
mvn help:evaluate -Dexpression=project.version -q -DforceStdout
But I'm okay with leaving the XML parsing, since this is what we do in the set-release-version.py
anyway.
Co-authored-by: Alexander Dümont <[email protected]>
excluded-check-runs: | ||
description: "A JSON object, where the keys are the names of the workflows to exclude. The values are a list of step names to ignore. If the list is empty, all steps of the workflow will be ignored." | ||
required: false | ||
default: '{\"${{ github.workflow }}\": []}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Question)
Doesn't this mean by default "all steps of workflow ${{ github.workflow }}" will be ignored? This doesn't have an effect on the action? Wouldn't default "{}" better fit, i.e. to not ignore anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole file is unreadable. If it was approved for the Cloud SDK we can also approve it of the AI SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you had higher standards for AI SDK (than Cloud SDK) 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the whole generation of pom files with plugins script. Maybe we get rid of this in 2030 😁
pr-ref: ${{ steps.determine-branch-names.outputs.CODE_BRANCH_NAME }} | ||
excluded-check-runs: | | ||
{ | ||
\"Continuous Integration\": [\"Run BlackDuck Scan\", \"Run Security Rating\"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Minor/Question)
This is a leftover from copying right? We don't use Blackduck in this repo, AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do believe the pr-is-mergeable
action is not working at all. Those parameters don't do anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the deploy-exclusion logic, I would approve the PR.
Maybe we can explore other options than explicitly "skipping" two specific executions of one specific plugin. Like here.
Co-authored-by: Alexander Dümont <[email protected]>
Context
AI/ai-sdk-java-backlog#65.
Have a release script ready and tested before our release date.
Feature scope:
Definition of Done
Aligned changes with the JavaScript SDKDocumentation updatedRelease notes updated