Reduce duplication of StreamingResponseHandlers #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
reviewed
Jan 7, 2025
| * @since 1.1.0 | ||
| */ | ||
| @Slf4j | ||
| public class ClientStreamingHandler<D extends StreamedDelta, E extends ClientException> { |
There was a problem hiding this comment.
(Comment)
- The new class is now public, before it was package-private.
- It is no longer immutable, with
JACKSONbeing modifiable.
newtork
reviewed
Jan 7, 2025
core/src/main/java/com/sap/ai/sdk/core/commons/ClientStreamingHandler.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 7, 2025
core/src/main/java/com/sap/ai/sdk/core/commons/ClientStreamingHandler.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 7, 2025
core/src/main/java/com/sap/ai/sdk/core/commons/ClientStreamingHandler.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 7, 2025
core/src/main/java/com/sap/ai/sdk/core/commons/ClientStreamingHandler.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 7, 2025
core/src/main/java/com/sap/ai/sdk/core/commons/IterableStreamConverter.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 7, 2025
newtork
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#111.
Feature scope:
OrchestrationStreamingHandlerandOpenAiStreamingHandlerinto a genericClientStreamingHandlerDefinition of Done
Aligned changes with the JavaScript SDKDocumentation updatedRelease notes updated