generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sample App] Content filtering demo #256
Open
rpanackal
wants to merge
11
commits into
main
Choose a base branch
from
filter-docs-demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove old combined tests - Update Orchestration service, test and controller
- Make inout and output filtering reachable from html
newtork
reviewed
Jan 3, 2025
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 3, 2025
sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java
Outdated
Show resolved
Hide resolved
- move handling to controller - update docs/signature to tag throwing methods
rpanackal
force-pushed
the
filter-docs-demo
branch
from
January 3, 2025 17:32
445f8dd
to
43b69cf
Compare
newtork
reviewed
Jan 7, 2025
...le-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 7, 2025
newtork
reviewed
Jan 7, 2025
- streamline error handling at endpoint - extends docs
newtork
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#126.
To demonstrate handling exception of input and output filters in an orchestration request.
Behaviour demonstrated
chatCompletion
.getContent()
).Feature scope:
Definition of Done
Aligned changes with the JavaScript SDKDocumentation updatedRelease notes updated