Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample App] Content filtering demo #256

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[Sample App] Content filtering demo #256

wants to merge 11 commits into from

Conversation

rpanackal
Copy link
Member

@rpanackal rpanackal commented Jan 2, 2025

Context

AI/ai-sdk-java-backlog#126.

To demonstrate handling exception of input and output filters in an orchestration request.

Behaviour demonstrated

  • When user triggers the input filter, an exception or “400 Bad Request” surfaces immediately on calling chatCompletion.
  • When user triggers the output filter, the user only discovers that when they try to read the content (getContent()).

Feature scope:

  • Update tests, static file and service class.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

Roshin Rajan Panackal added 5 commits January 2, 2025 16:09
- Remove old combined tests
- Update Orchestration service, test and controller
- Make inout and output filtering reachable from html
@rpanackal rpanackal self-assigned this Jan 3, 2025
@rpanackal rpanackal added the please-review Request to review a pull-request label Jan 3, 2025
@rpanackal rpanackal removed the please-review Request to review a pull-request label Jan 3, 2025
- move handling to controller
- update docs/signature to tag throwing methods
@rpanackal rpanackal added the please-review Request to review a pull-request label Jan 3, 2025
Roshin Rajan Panackal and others added 3 commits January 7, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Request to review a pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants