-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🚀 Responsive Enhancements and File Separation for #1 #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on organizing the file structure and improving code readability!
Before merging this PR, I have a few suggestions for modifications:
-
KeyboardLayout
(768–976px screen width)
The keyboard layout becomes messy in this screen size range. You might want to either hide the keyboard entirely or resize it to ensure it fits well within the screen. -
Spacing between
Panel
andtyping-container
(PC screen size)
On larger screens, thePanel
andtyping-container
feel a bit cramped. Adding some extra space between these elements will enhance the layout and make it visually more appealing. -
typeInput
andtypeWords
positioning (Mobile screen)
On smaller screens, these elements are stacked on top of each other, which makes it difficult to follow the typing flow. I suggest exploring a different arrangement that makes it easier for users to track the next character to type.
Looking forward to seeing your updates! Keep up the great work! 🚀
I made the changes, but I need more time and ideas to apply your suggestions! Point 3 The left key is not captured properly. - Fixed The background color of the button when click is not apply - Fixed |
Hi @S0KPiseth, Thank you for your feedback and suggestions earlier. I've made some updates but need to know if there's anything more I should improve or address. If you feel there's no further work needed, I would appreciate your confirmation so we can move forward. Otherwise, I'll be happy to continue making adjustments based on your guidance. If it's better to close this PR without merging, I understand and wouldn't want to waste resources keeping it open unnecessarily. Looking forward to your thoughts! 😊 Best regards, |
Pull Request Description:
This PR addresses the responsiveness improvement mentioned in #1 and includes the following updates:
Changes Made
Note Before Merging
While the build works as intended, some styling adjustments are still required to match the demo page's appearance (AlphaKeys Demo).
Ensure you add the following environment variable to GitHub: VITE_RANDOM_WORD_API_URL