Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🚀 Responsive Enhancements and File Separation for #1 #3

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AriajSarkar
Copy link

Pull Request Description:

This PR addresses the responsiveness improvement mentioned in #1 and includes the following updates:

Changes Made

  • Responsiveness: Adjusted layout and components to ensure proper scaling across different screen sizes. ✅
  • File Separation: Refactored the codebase by splitting large files into smaller, modular parts for better maintainability and readability.
  • Build Confirmation: Verified that the build is working perfectly after the updates.

Note Before Merging

  1. Styling Updates:
    While the build works as intended, some styling adjustments are still required to match the demo page's appearance (AlphaKeys Demo).
  2. Environment Variable:
    Ensure you add the following environment variable to GitHub: VITE_RANDOM_WORD_API_URL

Copy link
Owner

@S0KPiseth S0KPiseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on organizing the file structure and improving code readability!

Before merging this PR, I have a few suggestions for modifications:

  1. KeyboardLayout (768–976px screen width)
    The keyboard layout becomes messy in this screen size range. You might want to either hide the keyboard entirely or resize it to ensure it fits well within the screen.

  2. Spacing between Panel and typing-container (PC screen size)
    On larger screens, the Panel and typing-container feel a bit cramped. Adding some extra space between these elements will enhance the layout and make it visually more appealing.

  3. typeInput and typeWords positioning (Mobile screen)
    On smaller screens, these elements are stacked on top of each other, which makes it difficult to follow the typing flow. I suggest exploring a different arrangement that makes it easier for users to track the next character to type.

Looking forward to seeing your updates! Keep up the great work! 🚀

src/components/Button/Button.jsx Outdated Show resolved Hide resolved
src/components/Button/Button.jsx Outdated Show resolved Hide resolved
@AriajSarkar
Copy link
Author

AriajSarkar commented Jan 7, 2025

I made the changes, but I need more time and ideas to apply your suggestions! Point 3

The left key is not captured properly. - Fixed

The background color of the button when click is not apply - Fixed
while the code is successfully apply button animation I wanted to keep the class newbutton so that the background color of the clicked button is different from the one that is not. - DONE

@AriajSarkar
Copy link
Author

Hi @S0KPiseth,

Thank you for your feedback and suggestions earlier. I've made some updates but need to know if there's anything more I should improve or address. If you feel there's no further work needed, I would appreciate your confirmation so we can move forward. Otherwise, I'll be happy to continue making adjustments based on your guidance.

If it's better to close this PR without merging, I understand and wouldn't want to waste resources keeping it open unnecessarily. Looking forward to your thoughts! 😊

Best regards,
@AriajSarkar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants