Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the hash Multimixer-128 #591

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ members = [
"md2",
"md4",
"md5",
"multimixer-128",
"ripemd",
"sha1",
"sha1-checked",
Expand Down
12 changes: 12 additions & 0 deletions multimixer-128/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[package]
name = "multimixer-128"
version = "0.1.0"
edition = "2021"

[dependencies]
digest = "=0.11.0-pre.8"
rand_chacha = "0.3.1"

[dev-dependencies]
digest = { version = "=0.11.0-pre.8", features = ["dev"] }
hex-literal = "0.4.1"
1 change: 1 addition & 0 deletions multimixer-128/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
An implementation based on the paper [Multimixer-128: Universal Keyed Hashing Based on Integer Multiplication](https://eprint.iacr.org/2023/1357) and [the reference code](https://github.com/Parisaa/Multimixer/tree/main/ReferenceCode). ALso check out this repo: [itzmeanjan/multimixer-128](https://github.com/itzmeanjan/multimixer-128).
15 changes: 15 additions & 0 deletions multimixer-128/benches/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#![feature(test)]
extern crate test;

use digest::bench_update;
use digest::crypto_common::KeyInit;
use multimixer_128::Multimixer;
use test::Bencher;
//Multimixer::from_core(MultimixerCore::dummy_bencher());
bench_update!(
Multimixer::new(&[0u8;32].into());
multimixer_10 10;
multimixer_100 100;
multimixer_1000 1000;
multimixer_10000 10000;
);
224 changes: 224 additions & 0 deletions multimixer-128/src/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,224 @@
use core::fmt;

use digest::crypto_common::{InvalidLength, Key, KeyInit, KeySizeUser};
pub use digest::{self, Digest};

use digest::typenum::Unsigned;
use digest::{
consts::{U32, U64},
core_api::{
AlgorithmName, Block, BlockSizeUser, BufferKindUser, CoreWrapper, FixedOutputCore,
UpdateCore,
},
HashMarker, OutputSizeUser,
};
use rand_chacha::rand_core::{RngCore, SeedableRng};
use rand_chacha::ChaCha8Rng;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the chacha20 crate instead.


const BLOCKSIZE: usize = 32;

#[derive(Clone)]
pub struct MultimixerCore {
key_blocks: Vec<Block<Self>>,
block_sums: [u64; 8usize],
block_index: usize,
rng: Option<ChaCha8Rng>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks... suspicious. If you want to make code generic over key blocks generator, I think it's better to make it generic over closure.

}

pub type Multimixer = CoreWrapper<MultimixerCore>;

impl MultimixerCore {
fn compress(&mut self, message_block: &Block<Self>) {
let mut x: [u32; 4usize] = [0u32; 4];
//let mut h = [0u32; 4];
let mut y = [0u32; 4];
//let mut k = [0u32; 4];
let mut a = [0u32; 4];
let mut b = [0u32; 4];
let mut p = [0u32; 4];
let mut q = [0u32; 4];

let (h, k) = if let Some(ref mut rng) = self.rng.as_mut() {
let mut h = [0u32; 4];
let mut k = [0u32; 4];

for i in 0..4 {
h[i] = rng.next_u32();
k[i] = rng.next_u32();
}
(h, k)
} else {
let mut h = [0u32; 4];
let mut k = [0u32; 4];
for i in 0..4 {
h[i] = u32::from_ne_bytes([
self.key_blocks[self.block_index][i * 4],
Copy link
Member

@newpavlov newpavlov Jun 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with messages bigger than key size? IIUC this code will panic.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct, actually the message and key should be equal in size. I first created the algorithm with a key, but then also implemented a PRNG with a seed. I really wanted to bench the code, and for this I would need a really big key. Ideally I would maybe create two different hash-classes, Multimixer-128 and Multimixer-128-PRNG. I think this would solve the other comments as well.

self.key_blocks[self.block_index][i * 4 + 1],
self.key_blocks[self.block_index][i * 4 + 2],
self.key_blocks[self.block_index][i * 4 + 3],
]);
k[i] = u32::from_ne_bytes([
self.key_blocks[self.block_index][i * 4 + 16],
self.key_blocks[self.block_index][i * 4 + 17],
self.key_blocks[self.block_index][i * 4 + 18],
self.key_blocks[self.block_index][i * 4 + 19],
]);
}
(h, k)
};

for i in 0..4 {
x[i] = u32::from_ne_bytes([
message_block[i * 4],
message_block[1 + i * 4],
message_block[2 + i * 4],
message_block[3 + i * 4],
]);
y[i] = u32::from_ne_bytes([
message_block[16 + i * 4],
message_block[17 + i * 4],
message_block[18 + i * 4],
message_block[19 + i * 4],
]);

a[i] = x[i].wrapping_add(h[i]);
b[i] = y[i].wrapping_add(k[i]);
}

for i in 0..4 {
p[i] = a[i]
.wrapping_add(a[(i + 1) % 4])
.wrapping_add(a[(i + 2) % 4]);
q[i] = b[(i + 1) % 4]
.wrapping_add(b[(i + 2) % 4])
.wrapping_add(b[(i + 3) % 4]);
}

let block_res = [
a[0] as u64 * b[0] as u64,
a[1] as u64 * b[1] as u64,
a[2] as u64 * b[2] as u64,
a[3] as u64 * b[3] as u64,
p[0] as u64 * q[0] as u64,
p[1] as u64 * q[1] as u64,
p[2] as u64 * q[2] as u64,
p[3] as u64 * q[3] as u64,
];

self.block_sums
.iter_mut()
.zip(block_res.iter())
.for_each(|(sum, &res)| {
*sum = sum.wrapping_add(res);
});

self.block_index += 1;
}

fn finalize(&self, out: &mut digest::Output<Self>) {
for (i, block) in self.block_sums.iter().enumerate() {
let bytes = block.to_ne_bytes(); // Convert u64 to little-endian byte array
for (j, &byte) in bytes.iter().enumerate() {
out[i * 8 + j] = byte;
}
}
}
}

impl KeySizeUser for MultimixerCore {
type KeySize = U32;

fn key_size() -> usize {
Self::KeySize::USIZE
}
}

impl KeyInit for MultimixerCore {
//Uses the key to initialize ChaCha8Rng RNG and fills the key_blocks array
fn new(key: &Key<Self>) -> Self {
Self {
block_sums: [0; 8],
key_blocks: Vec::new(),
block_index: 0,
rng: Some(ChaCha8Rng::from_seed(
key.as_slice()
.try_into()
.expect("Key needs to be able to use as seed."),
)),
}
}

//Uses key instead of RNG, needs to be same size as message.
fn new_from_slice(key: &[u8]) -> Result<Self, InvalidLength> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, T::new(&key) and T::new_from_slice(&key).unwrap() should produce the same result for the same key.

let key_block_size = <Self as KeySizeUser>::KeySize::USIZE;
if key.len() % key_block_size != 0 {
return Err(InvalidLength);
}
let mut s = Self {
block_sums: [0; 8],
key_blocks: Vec::new(),
block_index: 0,
rng: None,
};

for block in key.chunks(key_block_size) {
let array: [u8; BLOCKSIZE] = block
.try_into()
.expect("Key chunk is not of length 32 bytes");
s.key_blocks.push(array.into());
}
Ok(s)
}
}

impl HashMarker for MultimixerCore {}

impl BlockSizeUser for MultimixerCore {
fn block_size() -> usize {
32usize
}

type BlockSize = U32;
}

impl BufferKindUser for MultimixerCore {
type BufferKind = digest::block_buffer::Eager;
}

impl OutputSizeUser for MultimixerCore {
type OutputSize = U64;

fn output_size() -> usize {
64usize
}
}

impl UpdateCore for MultimixerCore {
fn update_blocks(&mut self, blocks: &[Block<Self>]) {
for block in blocks {
self.compress(block);
}
}
}

impl FixedOutputCore for MultimixerCore {
fn finalize_fixed_core(
&mut self,
_buffer: &mut digest::core_api::Buffer<Self>,
out: &mut digest::Output<Self>,
) {
self.finalize(out);
}
}

impl AlgorithmName for MultimixerCore {
fn write_alg_name(f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
f.write_str("Multimixer-128")
}
}

impl fmt::Debug for MultimixerCore {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.write_str("MultimixerCore { ... }")
}
}
38 changes: 38 additions & 0 deletions multimixer-128/tests/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
use digest::crypto_common::KeyInit;
use digest::FixedOutput;
use digest::Update;
use hex_literal::hex;

use multimixer_128::Multimixer;

#[test]
fn multimixer_10_test() {
let key = &hex!("4420823cfde6f1c26b30f90ec7dd01e4887534a20f0b0d04c36ed80e71e0fd77");
let mut h = Multimixer::new(key.into());
let data = [0; 100];
digest::Update::update(&mut h, &data[..]);
}

#[test]
fn multimixer_simple_test() {
let key = &hex!("4420823cfde6f1c26b30f90ec7dd01e4887534a20f0b0d04c36ed80e71e0fd77");
let message = &hex!("b07670eb940bd5335f973daad8619b91ffc911f57cced458bbbf2ce03753c9bd");
let mut h = Multimixer::new_from_slice(key).unwrap();
h.update(message);
assert_eq!(
h.finalize_fixed().as_slice(),
&hex!("aca6cbf6480d9b17bb9d13efbb3589596ca1ce7d3ae4edac586d77e22313b5189f6c97c2a910636df227850c398ca01b92ab25c1ccec360e4020eec91331a383")[..]
);
}

#[test]
fn multimixer_simple_160_test() {
let key = &hex!("0702f5a3c49364cc514d0f07c64a1dc2824228ec9b07121f42158c3cdd2e610eff428e62e5c7a889857c7d1e59b3db1fb4d366d9238825805a314d1e68db161b2ef0bd32a0144010e241cae40c8a2e80a62b9a11c41d85a04285c23b9b30d97d69a9adc8f63542e50f955066bdc7a631d1b040211699a0d598a3b48ba6043e4ca2a6a723e78ff5e8bac2281c4418fb807dadb9bdce9dedae550e4b807144395e");
let message = &hex!("d21932883668852228256f58dd0bbcf9917066fc78d9e7bb60f62583d06704c2f927ced914b4ea036199023d9aa190d2d19de79a43e347538104d912bcd7cd90092e2e02c489ed8bbef6acc6e93bf7b54ad44b095885bc4193d38493d78cddabf86efbcdd92e2042694c750d34814ff532cc5f012dda1a6fd8b11834d63c878e5bf5186d2cc73fe596fec93bf5364cc5675583d593fc6dacf83404b1881ce199");
let mut h = Multimixer::new_from_slice(key).unwrap();
h.update(message);
assert_eq!(
h.finalize_fixed().as_slice(),
&hex!("fa80bf97fff5b9b014b0691c27907b1f04ac2debd24f964b9ae546d269d6eca934762c68a377114213591c04a762bb331eafe51633c06ee7304fc8dca2c88604")[..]
);
}
Loading