Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoxedUint: Add impls for stack allocated types #650

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Aug 15, 2024

Adds Add impls for BoxedUint for the following rhs types:

  • Uint<LIMBS>
  • u8
  • u16
  • u32
  • u64
  • u128

The primitive integer types convert to Uint<LIMBS> then leverate the Add impl for that.

See also: #585

@tarcieri tarcieri marked this pull request as draft August 15, 2024 01:22
@tarcieri
Copy link
Member Author

Some tests here would be good

@tarcieri tarcieri force-pushed the boxeduint/primitive-ops branch 2 times, most recently from 1acc85b to 65aced0 Compare August 16, 2024 03:03
@tarcieri tarcieri changed the title [WIP] BoxedUint: Add impls for stack allocated types BoxedUint: Add impls for stack allocated types Aug 16, 2024
@tarcieri tarcieri marked this pull request as ready for review August 16, 2024 03:04
Adds `Add` impls for `BoxedUint` for the following `rhs` types:

- `Uint<LIMBS>`
- `u8`
- `u16`
- `u32`
- `u64`
- `u128`

The primitive integer types convert to `Uint<LIMBS>` then leverate the
`Add` impl for that.
@tarcieri tarcieri force-pushed the boxeduint/primitive-ops branch from 65aced0 to fc87088 Compare August 16, 2024 03:07
@tarcieri tarcieri merged commit d114863 into master Aug 16, 2024
18 checks passed
@tarcieri tarcieri deleted the boxeduint/primitive-ops branch August 16, 2024 03:18
tarcieri added a commit that referenced this pull request Aug 16, 2024
Adds `Sub` impls for `BoxedUint` for the following `rhs` types,
similar to what #650 did for `Add`:

- `Uint<LIMBS>`
- `u8`
- `u16`
- `u32`
- `u64`
- `u128`

The primitive integer types convert to `Uint<LIMBS>` then leverate the
`Sub` impl for that.
tarcieri added a commit that referenced this pull request Aug 16, 2024
Adds `Sub` impls for `BoxedUint` for the following `rhs` types,
similar to what #650 did for `Add`:

- `Uint<LIMBS>`
- `u8`
- `u16`
- `u32`
- `u64`
- `u128`

The primitive integer types convert to `Uint<LIMBS>` then leverate the
`Sub` impl for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant