Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh-key: add SshSig serializing/deserializing using serde #264

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

MicroPanda123
Copy link
Contributor

Hello

I'm making a web server, which operates on SSH signatures, and I noticed that I could not include SshSig in my Serde Deserialized struct, so I had to parse it manually. So I decided to fork and add this functionality.

Cheers!

ssh-key/src/sshsig.rs Outdated Show resolved Hide resolved
ssh-key/src/sshsig.rs Outdated Show resolved Hide resolved
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise this looks fine

@tarcieri
Copy link
Member

Let's see if my suggestion works 😉

@tarcieri tarcieri changed the title Added SshSig serializing/deserializing using serde ssh-key: add SshSig serializing/deserializing using serde Aug 13, 2024
@tarcieri tarcieri merged commit 98d6448 into RustCrypto:master Aug 13, 2024
14 checks passed
@tarcieri
Copy link
Member

Thanks!

@MicroPanda123 MicroPanda123 deleted the sshsig-serde branch August 13, 2024 16:23
@MicroPanda123
Copy link
Contributor Author

Woooo!!!
Awesome, thanks!

@MicroPanda123
Copy link
Contributor Author

MicroPanda123 commented Aug 13, 2024

@tarcieri Mind if I ask if you could perhaps push it to crates.io as 0.7.0-pre?
My project uses that, so I'd like it to be available, if you don't mind.
Thanks

@tarcieri
Copy link
Member

tarcieri commented Aug 13, 2024

0.7.0-pre.0 is already out, but I can publish another prerelease

@MicroPanda123
Copy link
Contributor Author

Yes I'm aware just wanted it to include this PR, thank you :)

@williamdes
Copy link

About versions, can you also write notes as releases please?
https://github.com/RustCrypto/SSH/releases

I would love being notified so I can bump afterwards

@tarcieri
Copy link
Member

We do write release notes, but for final releases as opposed to prereleases.

Often times we'll go back and forth on various features during development, which makes it difficult to maintain prerelease changelogs.

@williamdes
Copy link

We do write release notes, but for final releases as opposed to prereleases.

Often times we'll go back and forth on various features during development, which makes it difficult to maintain prerelease changelogs.

Okay, do you mean that you will do for the next stable?
I can not see any release written on the page

@tarcieri
Copy link
Member

We’ll publish a CHANGELOG for a stable release. We don’t use the GitHub releases feature. I use it for Rust binaries, but I don’t think it makes sense for library crates and in particular multi-library-crate repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants