-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh-key: add SshSig
serializing/deserializing using serde
#264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise this looks fine
Let's see if my suggestion works 😉 |
SshSig
serializing/deserializing using serde
Thanks! |
Woooo!!! |
@tarcieri Mind if I ask if you could perhaps push it to crates.io as 0.7.0-pre? |
0.7.0-pre.0 is already out, but I can publish another prerelease |
Yes I'm aware just wanted it to include this PR, thank you :) |
About versions, can you also write notes as releases please? I would love being notified so I can bump afterwards |
We do write release notes, but for final releases as opposed to prereleases. Often times we'll go back and forth on various features during development, which makes it difficult to maintain prerelease changelogs. |
Okay, do you mean that you will do for the next stable? |
We’ll publish a CHANGELOG for a stable release. We don’t use the GitHub releases feature. I use it for Rust binaries, but I don’t think it makes sense for library crates and in particular multi-library-crate repos. |
Hello
I'm making a web server, which operates on SSH signatures, and I noticed that I could not include
SshSig
in my Serde Deserialized struct, so I had to parse it manually. So I decided to fork and add this functionality.Cheers!