Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2670: Bugfixing #2687

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Issue #2670: Bugfixing #2687

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e611e1
Issue #2670: Replaced user id param in TicketAcl call with customerus…
stefanhaerter Nov 17, 2023
3b0abc4
Issue #2670: Removed obsolete and erroneous short-name variable.
stefanhaerter Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions Kernel/Modules/CustomerTicketProcess.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3082,11 +3082,11 @@ sub _StoreActivityDialog {
# call ticket ACLs for DynamicFields to check field visibility
my $ACLResult = $TicketObject->TicketAcl(
$Param{GetParam}->%*,
Action => $Self->{Action},
ReturnType => 'Form',
ReturnSubType => '-',
Data => \%DynamicFieldAcl,
UserID => $Self->{UserID},
Action => $Self->{Action},
ReturnType => 'Form',
ReturnSubType => '-',
Data => \%DynamicFieldAcl,
CustomerUserID => $Self->{UserID},
);
if ($ACLResult) {
%Visibility = map { 'DynamicField_' . $_->{Name} => 0 } @{$DynamicField};
Expand Down Expand Up @@ -3154,11 +3154,11 @@ sub _StoreActivityDialog {
# set possible values filter from ACLs
my $ACL = $TicketObject->TicketAcl(
$Param{GetParam}->%*,
Action => $Self->{Action},
ReturnType => 'Ticket',
ReturnSubType => 'DynamicField_' . $DynamicFieldConfig->{Name},
Data => \%AclData,
UserID => $Self->{UserID},
Action => $Self->{Action},
ReturnType => 'Ticket',
ReturnSubType => 'DynamicField_' . $DynamicFieldConfig->{Name},
Data => \%AclData,
CustomerUserID => $Self->{UserID},
);
if ($ACL) {
my %Filter = $TicketObject->TicketAclData();
Expand Down Expand Up @@ -3392,7 +3392,6 @@ sub _StoreActivityDialog {

# some fields should be skipped for the customer interface
next DIALOGFIELD if ( grep { $_ eq $CurrentField } @{$SkipFields} );
my $FieldNameShort = substr( $CurrentField, length('DynamicField_') );

if ( !IsHashRefWithData( $ActivityDialog->{Fields}->{$CurrentField} ) ) {
$LayoutObject->CustomerFatalError(
Expand Down