Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to address deprecation warnings in jQuery 3.5 + #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changes to address deprecation warnings in jQuery 3.5 + #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions jquery.uploadifive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Released under the MIT License
var methods = {

init : function(options) {

return this.each(function() {

// Create a reference to the jQuery DOM object
Expand Down Expand Up @@ -40,7 +40,7 @@ Released under the MIT License
'auto' : true, // Automatically upload a file when it's added to the queue
'buttonClass' : false, // A class to add to the UploadiFive button
'buttonText' : 'Select Files', // The text that appears on the UploadiFive button
'checkScript' : false, // Path to the script that checks for existing file names
'checkScript' : false, // Path to the script that checks for existing file names
'dnd' : true, // Allow drag and drop into the queue
'dropTarget' : false, // Selector for the drop target
'fileObjName' : 'Filedata', // The name of the file object to use in your server-side script
Expand Down Expand Up @@ -109,7 +109,7 @@ Released under the MIT License
'position' : 'absolute',
'right' : '-3px',
'top' : '-3px',
'z-index' : 999
'z-index' : 999
});

// Create a new input
Expand All @@ -128,7 +128,7 @@ Released under the MIT License
input.attr('accept', settings.fileType);
}
// Set the onchange event for the input
input.bind('change', function() {
input.on('change', function() {
$data.queue.selected = 0;
$data.queue.replaced = 0;
$data.queue.errors = 0;
Expand Down Expand Up @@ -283,7 +283,7 @@ Released under the MIT License
// Add an ID to the queue item
file.queueItem.attr('id', settings.id + '-file-' + $data.fileID++);
// Bind the close event to the close button
file.queueItem.find('.close').bind('click', function() {
file.queueItem.find('.close').on('click', function() {
methods.cancel.call($this, file);
return false;
});
Expand All @@ -306,7 +306,7 @@ Released under the MIT License
$data.error('FORBIDDEN_FILE_TYPE', file);
}
// Check the filesize
if (file.size > settings.fileSizeLimit && settings.fileSizeLimit !== 0) {
if (file.length > settings.fileSizeLimit && settings.fileSizeLimit !== 0) {
$data.error('FILE_SIZE_LIMIT_EXCEEDED', file);
} else {
$data.queue.queued++;
Expand Down Expand Up @@ -445,7 +445,7 @@ Released under the MIT License
eol = '\r\n',
binFile = '';

// Build an RFC2388 String
// Build an RFC2388 String
binFile += dashes + boundary + eol;
// Generate the headers
binFile += 'Content-Disposition: form-data; name="' + settings.fileObjName + '"';
Expand Down Expand Up @@ -476,11 +476,11 @@ Released under the MIT License
if (status == 404) {
$data.error('404_FILE_NOT_FOUND', file, uploadAll);
} else {
if (file.xhr.responseText != 'Invalid file type.') {
if (file.xhr.responseText != 'Invalid file type.') {
$data.uploadComplete(e, file, uploadAll);
} else {
$data.error(file.xhr.responseText, file, uploadAll);
}
}
}
}, false);

Expand Down Expand Up @@ -549,7 +549,7 @@ Released under the MIT License
file.queueItem.addClass('error')
// Output the error in the queue item
.find('.fileinfo').html(' - ' + errorMsg);
// Hide the
// Hide the
file.queueItem.find('.progress').remove();
}
// Trigger the error event
Expand Down Expand Up @@ -616,10 +616,10 @@ Released under the MIT License
// Style the button wrapper
$data.button.css({
'height' : settings.height,
'line-height' : settings.height + 'px',
'line-height' : settings.height + 'px',
'overflow' : 'hidden',
'position' : 'relative',
'text-align' : 'center',
'text-align' : 'center',
'width' : settings.width
});

Expand Down Expand Up @@ -766,9 +766,9 @@ Released under the MIT License
if (typeof settings.onCancel === 'function') {
settings.onCancel.call($this, file);
}

});

},

// Upload the files in the queue
Expand Down Expand Up @@ -818,7 +818,7 @@ Released under the MIT License
$data.uploadFile(_file, true);
}
});
if ($('#' + settings.queueID).find('.uploadifive-queue-item').not('.error, .complete').size() === 0) {
if ($('#' + settings.queueID).find('.uploadifive-queue-item').not('.error, .complete').length() === 0) {
$data.queueComplete();
}
} else {
Expand Down Expand Up @@ -849,7 +849,7 @@ Released under the MIT License
var $this = $(this),
$data = $this.data('uploadifive'),
settings = $data.settings;

// Clear the queue
methods.clearQueue.call($this);
// Destroy the queue if it was created
Expand Down Expand Up @@ -885,4 +885,4 @@ Released under the MIT License

};

})(jQuery);
})(jQuery);